Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication field classes to reduce complexity #792

Merged
merged 10 commits into from
Dec 30, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 30, 2022

Refactors the new field value classes to reduce complexity, primarily by overriding base class constructors instead of variadic argument unpacking.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #792 (399badb) into publications-feature (e4bdcb2) will increase coverage by 0.05%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #792      +/-   ##
==========================================================
+ Coverage                   99.88%   99.94%   +0.05%     
+ Complexity                   2850     1424    -1426     
==========================================================
  Files                         348      174     -174     
  Lines                        7166     3581    -3585     
==========================================================
- Hits                         7158     3579    -3579     
+ Misses                          8        2       -6     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...tions/Models/PublicationFieldValues/ArrayField.php
...s/PublicationFieldValues/PublicationFieldValue.php
...cations/Models/PublicationFieldValues/TagField.php
...ework/src/Console/Commands/BuildRssFeedCommand.php
...amework/Features/Navigation/BaseNavigationMenu.php
...ckages/framework/src/Foundation/Facades/Router.php
...es/framework/src/Framework/HydeServiceProvider.php
.../Framework/Services/DocumentationSearchService.php
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Refactor publication field classes Refactor publication field classes to reduce complexity Dec 30, 2022
@caendesilva caendesilva marked this pull request as ready for review December 30, 2022 19:04
@caendesilva caendesilva merged commit c15c614 into publications-feature Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants