Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create object representation for the tags.json file. #802

Merged
merged 33 commits into from
Jan 3, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 3, 2023

This refactor solves two problems:

  1. It groups together related logic in a single class
  2. It makes the data structure of the tags file more clear and structured thanks to rich type annotations

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #802 (82dc5df) into publications-feature (99d9ce4) will not change coverage.
The diff coverage is n/a.

❗ Current head 82dc5df differs from pull request most recent head 19233d8. Consider uploading reports for the commit 19233d8 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #802     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   2856      1444   -1412     
==========================================================
  Files                         332       167    -165     
  Lines                        7194      3628   -3566     
==========================================================
- Hits                         7194      3628   -3566     
Impacted Files Coverage Δ
...ework/Features/Publications/PublicationService.php 100.00% <0.00%> (ø)
...ework/Features/Publications/PublicationService.php
...rc/Framework/Exceptions/RouteNotFoundException.php
.../Framework/Features/Blogging/Models/PostAuthor.php
...ork/src/Foundation/Concerns/ForwardsFilesystem.php
...rk/Features/Publications/PublicationFieldTypes.php
...ramework/src/Foundation/Facades/FileCollection.php
...work/src/Framework/Concerns/ValidatesExistence.php
...framework/src/Console/Commands/ValidateCommand.php
...k/src/Framework/Views/Components/LinkComponent.php
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the create-publication-tags-model-class branch from 1244dfb to 66bee36 Compare January 3, 2023 11:58
@caendesilva caendesilva marked this pull request as ready for review January 3, 2023 12:25
@caendesilva caendesilva merged commit 96400ae into publications-feature Jan 3, 2023
@caendesilva caendesilva deleted the create-publication-tags-model-class branch January 3, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants