Code

Refactor publication type validation#842

Code

Merged

caendesilva merged 65 commits intopublications-featurehydephp/develop:publications-featurefrom refactor-publication-type-validationhydephp/develop:refactor-publication-type-validationCopy head branch name to clipboardJan 18, 2023

+300-271

Commits

Commits on Jan 18, 2023

• Restructure buffering to flatten internal array

  caendesilva

  committed
  9b7d3cf

• Create ValidatesPublicationSchema.php

  caendesilva

  committed
  865c4b9

• Create ValidatesPublicationSchemaTest.php

  caendesilva

  committed
  bcfdc1f

• Create constructor

  caendesilva

  committed
  0c4e7b6

• Add array as the invoke function's return type

  caendesilva

  committed
  b798a40

• Change property type array to stdClass

  caendesilva

  committed
  779686c

• Extract logic to invokable action class

  caendesilva

  committed
  94b5edc

• Move tests for moved code from service to action

  caendesilva

  committed
  a54b4c0

• Inline and remove method PublicationService::validateSchemaFile

  caendesilva

  committed
  88f81dd

• Deprecate throw parameter

  caendesilva

  committed
  bc70705

• Replace boolean argument with fluent helper methods

  caendesilva

  committed
  b50f310

• Add rich type annotations

  caendesilva

  committed
  53a6940

• Apply fixes from StyleCI

  StyleCIBot

  committed
  30a4a19

• Merge branch 'publications-feature' into refactor-publication-type-validation

  caendesilva

  committed
  3e7e087

• Allow null return type as it's depends on supplied parameter value

  caendesilva

  committed
  7ca3d75

• Call the fluent errors method to get the errors

  caendesilva

  committed
  50c3260

• Use all instead of toArray for a more compact format

  Show description for 5bb0c74
  caendesilva

  committed
  5bb0c74

• Add type check to ensure property is an array before looping through it

  caendesilva

  committed
  66feecf

• Extract helper methods

  caendesilva

  committed
  42d2876

• Introduce local variables

  caendesilva

  committed
  86ca6c8

• Add array for the properties

  caendesilva

  committed
  1ba249d

• Convert associate array to indexed

  caendesilva

  committed
  b67d673

• Combine in the keys

  caendesilva

  committed
  25da044

• Merge properties array with rules array

  caendesilva

  committed
  28a8d21

• Assemble input dynamically

  caendesilva

  committed
  0bd0fbb

• Remove unnecessary array initializer as loop will never be empty

  caendesilva

  committed
  7960d42

• Inline unnecessary local variable

  caendesilva

  committed
  b76dddb

• Remove array combining that is no longer necessary

  caendesilva

  committed
  197c32c

• Rename helper methods

  caendesilva

  committed
  aebf7a9

• Extract helper method

  caendesilva

  committed
  f148ca1

• Convert arrow function to a traditional closure

  caendesilva

  committed
  fed351c

• Add return type annotation

  caendesilva

  committed
  3287b0f

• Expand type annotation

  caendesilva

  committed
  eea4160

• Replace collection mapper with foreach loop

  caendesilva

  committed
  b9b1521

• Revert "Replace collection mapper with foreach loop"

  Show description for 0238d8b
  caendesilva

  committed
  0238d8b

• Add array for warnings

  caendesilva

  committed
  7cbb769

• No need to save schema file here

  caendesilva

  committed
  56c58b6

• Revert "Add array for warnings"

  Show description for d571f0b
  caendesilva

  committed
  d571f0b

• Revert "Revert "Add array for warnings""

  Show description for 2fb3c26
  caendesilva

  committed
  2fb3c26

• Remove warnings from action as they add too much complexity

  Show description for da3c988
  caendesilva

  committed
  da3c988

• Introduce local variables

  caendesilva

  committed
  4f3e300

• Bring variable static declaration out of loop

  caendesilva

  committed
  3ffb756

• Assemble the input array dynamically

  caendesilva

  committed
  ff605f8

• Inline local variable

  caendesilva

  committed
  ed5a615

• Replace foreach loop with collection mapper

  caendesilva

  committed
  ab3bd31

• Revert "Replace foreach loop with collection mapper"

  Show description for 7e0791b
  caendesilva

  committed
  7e0791b

• Pluralize helper method name

  caendesilva

  committed
  53362e6

• Remove extra newline

  caendesilva

  committed
  b779fb7

• Convert internal collection representation to array so it can be pre-initialized

  caendesilva

  committed
  2ac726b

• Extract helper method

  caendesilva

  committed
  77c6df2

• Convert arrow function to a traditional closure

  caendesilva

  committed
  47d11fa

• Change closure to void

  caendesilva

  committed
  2266083

• Replace collection eacher with foreach loop

  caendesilva

  committed
  5df693a

• Extract method for repeated code

  caendesilva

  committed
  1b9875a

• Convert foreach loop to collect mapper

  caendesilva

  committed
  37ca029

• Convert closure to arrow function

  caendesilva

  committed
  6b01eae

• Revert "Convert closure to arrow function"

  Show description for cc23e0d
  caendesilva

  committed
  cc23e0d

• Rename parameter to be more generic

  caendesilva

  committed
  a0c681a

• Inline local variables

  caendesilva

  committed
  1e988a7

• Extract method for repeated code

  caendesilva

  committed
  840ec9d

• Apply fixes from StyleCI

  StyleCIBot

  committed
  2b1b7f6

• Initialize the array

  caendesilva

  committed
  f5266b0

• Clean up class properties

  caendesilva

  committed
  837040a

• Rename class ValidatesPublicationField to PublicationFieldValidator

  caendesilva

  committed
  5c221c0

• Rename class ValidatesPublicationSchema to PublicationSchemaValidator

  caendesilva

  committed
  95b1fd4