Refactor internal data store of LocalFeaturedImage $source property to not include directory information

[caendesilva]

Prior to this refactor, the $source property of LocalFeaturedImage classes was forced to start with _media/, and threw an exception if it did not. The value was then normalized to the desired format upon accessing the value.

This PR changes so that the internal data value no longer contain the path information, as it is instead prepended when accessing the value. To keep the internal state consistent, any leading _media/ prefixes are removed. Thus this change is entirely unbreaking as no usage outside the class is affected since the public accessors still function the same.

This change is important from an internal perspective however, as is more compatible with customizable media directories #920

[what-the-diff]

• The setSource method in the LocalFeaturedImage class was changed to remove a check for _media/ from the beginning of $source.
• A new test case was added that checks if an exception is thrown when constructing a LocalFeaturedImage with invalid source information (i.e., not starting with '_media').

Note from author: The AI comment below is just wrong. Please ignore it.

• In FeaturedImageTest, there are two changes:
  • One change removes an existing test case which checked whether or not exceptions were being thrown by passing invalid data into constructors for both classes; this has been replaced by more specific tests cases in each class's respective file (see Restore master project #1 and Merge Hyde/Framework into packages/framework #2).
  • Another change adds another test case to ensure that getContentLength() returns 0 on empty files instead of throwing errors as it did before (Remove Undue Complexity #4) . This also ensures that we don't have any unexpected behavior due to PHP 7+'s stricter type checking rules regarding return values from functions returning int types vs nullable int types like they used to be able too prior to version 7+.

[codecov]

Codecov Report

Merging #924 (1c295d5) into master (e796bb9) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #924     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1237      2474   +1237     
=============================================
  Files            145       290    +145     
  Lines           3269      6538   +3269     
=============================================
+ Hits            3269      6538   +3269     

Impacted Files	Coverage Δ
...amework/Features/Blogging/Models/FeaturedImage.php	100.00% <ø> (ø)
...rk/Features/Blogging/Models/LocalFeaturedImage.php	100.00% <100.00%> (ø)
...mework/src/Framework/Actions/StaticPageBuilder.php	100.00% <0.00%> (ø)
...es/framework/src/Support/Concerns/Serializable.php	100.00% <0.00%> (ø)
develop/packages/framework/src/Pages/HtmlPage.php	100.00% <0.00%> (ø)
...k/src/Framework/Views/Components/LinkComponent.php	100.00% <0.00%> (ø)
...rk/src/Console/Commands/PublishHomepageCommand.php	100.00% <0.00%> (ø)
...src/Framework/Exceptions/FileNotFoundException.php	100.00% <0.00%> (ø)
...ackages/framework/src/Console/Concerns/Command.php	100.00% <0.00%> (ø)
...ackages/framework/src/Markdown/Models/Markdown.php	100.00% <0.00%> (ø)
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.