Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pkgx integration #265

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

felipecrs
Copy link
Contributor

Description

This improves the pkgx integration through the following:

  • Now only pkgx-installed packages will be shown
    • pkgx can run any package without having to install it. When not installing, the package is just cached. The current implementation shows all currently cached packages, which in my opinion is not as useful as showing only the installed packages.
  • Fix tea -> pkgx on macOS
  • Check for pkgx regardless of the OS (they are working to support Windows, for example)

Relevant Links

Screenshots

The only thing you'll notice is the decreased number of packages shown in the list, as only the installed packages will be shown.

Additional context

N/A

@felipecrs
Copy link
Contributor Author

Before

WindowsTerminal_TmS0hHkUGH

After

image

@hykilpikonna
Copy link
Owner

hykilpikonna commented May 2, 2024

Right, this is definitely a better way of detecting pkgx packages. Still, I really hope they add a list packages option tho, that would work better in case any package has more than one binary or stub command. But they seem to be moving nowhere after the primary focus shifted to the crypto aspect ☹️

Anyways, thanks!!

@hykilpikonna hykilpikonna merged commit 73bb634 into hykilpikonna:master May 2, 2024
1 check passed
@felipecrs felipecrs deleted the improve-pkgx branch May 2, 2024 22:53
@felipecrs
Copy link
Contributor Author

I really hope they add a list packages option tho

Me too, for sure.

that would work better in case any package has more than one binary or stub command

Oh, this implementation handles it (through the sort -u).

But they seem to be moving nowhere after the primary focus shifted to the crypto aspect ☹️

Yeah, it's unfortunate to see pkgx project not receiving much love. But at least the pantry seems to be SUPER active: https://github.com/pkgxdev/pantry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants