Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all uses of features that are deprecated in Python 3.12 #2447

Merged
merged 6 commits into from
May 30, 2023
Merged

Replace all uses of features that are deprecated in Python 3.12 #2447

merged 6 commits into from
May 30, 2023

Conversation

Kodiologist
Copy link
Member

There are still some DeprecationWarnings produced by pytest itself, but these should be fixed by pytest-dev/pytest#10894.

scauligi
scauligi approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@scauligi scauligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

You should remove the pkgutil imports in hy/macros.py and hy/errors.py since they're no longer being used (and while you're in hy/errors.py you might as well remove the import of functools.reduce).

@Kodiologist
Copy link
Member Author

Sounds good. Done.

@Kodiologist Kodiologist merged commit 961e943 into hylang:master May 30, 2023
@Kodiologist Kodiologist deleted the nondeprecated branch May 30, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scauligi scauligi scauligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kodiologist @scauligi