#19 Pass positional arguments down to stdlib #23
Conversation
|
poke :) |
|
Thanks! Could you add docstrings to the tests in the style of https://plus.google.com/+JonathanLange/posts/YA3ThKWhSAj ? I know the original tests of structlog didn’t do that but that was also my way to enlightenment why one should do it. :) |
| @@ -183,6 +184,7 @@ def _proxy_to_logger(self, method_name, event=None, **event_kw): | |||
| """ | |||
| try: | |||
| args, kw = self._process_event(method_name, event, event_kw) | |||
| args = args[:] + event_args | |||
There was a problem hiding this comment.
Any reason why you copy args? Why not just args += event_args?
There was a problem hiding this comment.
I’m also a bit confused. There’s the addition of an formatter for stdlib strings but still the args won’t get passed into the processor chain but passed into the wrapped method instead? Am I missing something?
ISTM that there’s also no test for this behavior. :)
There was a problem hiding this comment.
This is actually old code, was needed my previous implementation and I forgot to remove it.
|
Would you mind helping out? :) @gcbirzan seems rather busy and my own stdlib logging expertise is rather limited. :( |
|
@hynek I can give it a shot, yes. |
|
Amazing! |
hynek
force-pushed
the
master
branch
2 times, most recently
from
b45b077
to
ba6593e
Compare
|
Closed via #34. |
Apparently, there's an error checking merge status :)