Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert-is-always-True in twisted tests #59

Closed
wants to merge 1 commit into from

Conversation

Callek
Copy link
Contributor

@Callek Callek commented Sep 15, 2015

This issue was found during my work on #58 (and is where I added myself to authors)

I don't feel this is worth adding to the changelog, and is the only place (other than #58) in which this was a problem afaict.

@Callek
Copy link
Contributor Author

Callek commented Sep 15, 2015

...looks like this is failing after fixing the assert, I don't admit to knowing enough of twisted to get this test right, without simultaneously worrying that I'll also break the thing its trying to test though...

@hynek
Copy link
Owner

hynek commented Sep 15, 2015

Yeah test suite fixes don't need a change log entry.

The tests seem to fail now tho. :)

@hynek
Copy link
Owner

hynek commented Sep 15, 2015

I guess that Failures aren't comparable. Will look at it when I'm back. Will probably need to split up the assert into an isinstance and comparing .value

@hynek hynek closed this in 85bff22 Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants