Fix color of timestamp of first log entry #73
Conversation
The timestamp of the first log entry appeared in black instead of white without sending `RESET_ALL` as first element.
Current coverage is 91.09% (diff: 0.00%)@@ master #73 diff @@
========================================
Files 13 13
Lines 739 696 -43
Methods 0 0
Messages 0 0
Branches 91 87 -4
========================================
- Hits 739 634 -105
- Misses 0 58 +58
- Partials 0 4 +4
|
|
heh you broke every single test :) |
|
Hm,... saw that when I got the coverage report from Codecov. |
|
to be honest not quite. the timestamps are always dimmer white for me…is some kind of formatting from your shell prompt bleeding into this? (that would be completely ok and should be fixed, I’m just trying to understand what’s going on) |
|
Huh, you are right. I just installed the project I'm working on on my Linux box at home with fish shell, and everything works fine. I'll try to give some details once I'm back at work tomorrow. |
|
Please do |
|
So, back at work - here are some facts: I'm using Windows 10, Python 3.4 or 3.5 in a virtualenv, everything is running in a Git-for-Windows Terminal in a ConEmu Window. When I log something using the However, the text is printed just fine, since selecting it reveals it: My logging configuration looks like this: import logging
import structlog
class ProcessorFormatter(logging.Formatter):
"""Custom stdlib logging formatter for structlog ``event_dict`` messages.
Apply a structlog processor to the ``event_dict`` passed as
``LogRecord.msg`` to convert it to loggable format (a string).
"""
def __init__(self, processor, fmt=None, datefmt=None, style='%'):
"""Keep reference to the ``processor``."""
super().__init__(fmt=fmt, datefmt=datefmt, style=style)
self.processor = processor
def format(self, record):
"""Extract structlog's ``event_dict`` from ``record.msg``.
Process a copy of ``record.msg`` since the some processors modify the
``event_dict`` and the ``LogRecord`` will be used for multiple
formatting runs.
"""
if isinstance(record.msg, dict):
msg_repr = self.processor(
record._logger, record._name, record.msg.copy())
return msg_repr
return record.getMessage()
def event_dict_to_message(logger, name, event_dict):
"""Pass the event_dict to stdlib handler for special formatting."""
return ((event_dict,), {'extra': {'_logger': logger, '_name': name}})
# Configure structlog stack.
structlog.configure(
processors=[
structlog.stdlib.filter_by_level,
structlog.stdlib.add_logger_name,
structlog.stdlib.add_log_level,
structlog.stdlib.PositionalArgumentsFormatter(),
structlog.processors.TimeStamper(
fmt='%Y-%m-%dT%H:%M:%S', utc=False),
structlog.processors.StackInfoRenderer(),
structlog.processors.format_exc_info,
# Do not include last processor that converts to a string for
# stdlib since we leave that to the handler's formatter.
event_dict_to_message,
],
context_class=dict,
logger_factory=structlog.stdlib.LoggerFactory(),
wrapper_class=structlog.stdlib.BoundLogger,
cache_logger_on_first_use=True,
)
# Cap console and file logs to user-defined level.
level = logging._nameToLevel.get(self.config['log_level'], logging.INFO)
# Use a StreamHandler with a ConsoleRenderer.
handler_stream = logging.StreamHandler(sys.stdout)
handler_stream.setFormatter(
ProcessorFormatter(processor=structlog.dev.ConsoleRenderer()))
handler_stream.setLevel(level)
# And use a FileHandler with a JSONRenderer, cap to user-defined level.
handler_file = logging.handlers.TimedRotatingFileHandler(
self.config['logfile'], encoding='utf-8',
# Rotate logfiles weekly on Monday, keep last 10 weeks.
when='W0', atTime=datetime.time(0, 0, 0), backupCount=10)
handler_file.setFormatter(
ProcessorFormatter(processor=structlog.processors.JSONRenderer()))
handler_file.setLevel(level)
# HWcom logger to debug level.
logger = structlog.get_logger('hwcom')
logger.setLevel(logging.DEBUG)
# Apply the handlers only to the root logger.
logging.root.setLevel(logging.WARNING)
logging.root.addHandler(handler_stream)
logging.root.addHandler(handler_file)These are the installed packages (
Not sure what other information could be relevant. Do you have any additional questions on how to replicate this? |
|
Nah, just fix the tests. :) |
|
Ok, I'll try as soon as I find the time. |
|
@fabianbuechler Solution with |
|
@insolite I don't really manage to create a pullrequest for this at the moment. Lot's of work with the kids... ;) Feel free to create a PR with my implementation if you like. |
|
FYI ProcessorFormatter has been added via #105 |
The timestamp of the first log entry appeared in black instead of white without sending
RESET_ALLas first element.