This repository has been archived by the owner on May 31, 2021. It is now read-only.
Add postbuild script for building storybook #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hyochan
pushed a commit
that referenced
this pull request
Aug 12, 2020
Fixed webpack.config.js file so it will correct previous solution and adding postbuild script for building storybook #259 Current solution (thx to @ndelangen @Marklb) fixed webpack.config.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building a storybook, the
iframe.htmllink is broken since that all starts with absolute path/app.js....I've added shell script to
postbuildscript so it will replace the wrongsrcstrings iniframe.html.The issue was resolved by @s-ong-c.
Related issue
storybookjs/storybook#11694
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn testoryarn test -uif you need to update snapshot.yarn lint