Lint and run tests as part of yarn prepare to improve safety

[hsource]

Motivation

While trying to work on this repository, I realized that the linting and tests were broken. To help ensure the tests and linting isn't broken by any new changes, I think it'd be great to run the linter and tests as part of the prepare release process.

Fix

1. Change yarn prepare to also run yarn lint && yarn test
   • Create a separate yarn build command so we can build while skipping the lint/test process
2. Fix the test by moving the mock to the outermost scope
3. Fix the linting by adding excludes to the typechecker

Testing

Ran yarn prepare and verified that it runs successfully.

[andresesfm]

Hello @hsource thank you for the contribution. Can you please describe how this change "improves safety". Also if you move the mock outside of describe how would you ad ios tests?

[hsource]

@andresesfm

Hello @hsource thank you for the contribution. Can you please describe how this change "improves safety".

Thanks for the questions! What I meant by this was that the typechecking (yarn lint:tsc) and tests (yarn test) seemed to have errors that weren't caught by CI.

Thinking about this more after your comment, I think we can revert this change and change prepare back to just run bob build again. Instead, we may want to just add yarn test to Github CI pipelines.

Also if you move the mock outside of describe how would you ad ios tests?

Right now, there aren't any iOS tests, so it's not a problem. jest.mock only seemed to work correctly at the top-level.

I think if we had iOS tests, I'd recommend renaming iap.test.ts to iap.android.test.ts and creating a separate iap.ios.test.ts that tests iOS logic.