Improve Context typing for custom contexts #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypergonial
requested changes
Nov 2, 2023
hypergonial
changed the title
hypergonial
approved these changes
Nov 10, 2023
So that people can subclass the context classes without typecheckers like pyright complaining
now tayne i can get into
Computer, load up Celery Man please.
Could you kick up the, uh, 4d3d3d3?
hypergonial
force-pushed
the
chore/use-context-typevar
branch
from
199a92d
to
47042d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that people can subclass the context classes without typecheckers like pyright complaining
(I am people)
100% untested
nox did not complain