Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable length_delimited deprecation warning. #321

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

carllerche
Copy link
Collaborator

Until tokio-rs/tokio#680 is resolved, we should allow using deprecated
APIs in the codec module.

Until tokio-rs/tokio#680 is resolved, we should allow using deprecated
APIs in the codec module.
@carllerche
Copy link
Collaborator Author

r+? @seanmonstar @hawkw

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a lot of things deprecated? When feasible, I prefer these allows to go as close to the warning as possible, to not hide new unexpected warnings.

@carllerche
Copy link
Collaborator Author

@seanmonstar there are a lot of specific locations... this is a short term fix, so I"m not super worried about being more specific.

@carllerche carllerche merged commit 9bbbe7e into master Oct 16, 2018
@carllerche carllerche deleted the fix-build branch October 16, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants