http-body-util: minor doc and lint fixes, raising msrv to 1.56 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It claimed `UnsyncBoxBody::new` creates a `BoxBody`. Not the end of the world, but still!
seanmonstar
reviewed
Dec 12, 2024
|
Ugh, clippy. Well, if you want to submit a fix for clippy too, I can merge more easily than I can code today. |
|
I'm not sure about the msrv thing. It's complaining about an unstable lint in a dependency, would that actually break compilation..? |
|
Hm, that's weird. I suppose it could break compilation... Want to just remove that lint? Once rustc decides to make it default, we'll get the benefits from free. |
|
It's futures-task that's failing here unfortunately, which looks like it's a transitive dependency? Apparently futures-task claims an MSRV of 1.56, and has for a while. |
|
Oh, we can bump it to that, it's fine. |
goto-bus-stop
changed the title
UnsyncBoxBody::new doc comment
seanmonstar
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It claimed
UnsyncBoxBody::newcreates aBoxBody. Not the end of the world, but still!