Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and fixes for remove_entry and remove_entry_mult #449

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Tests and fixes for remove_entry and remove_entry_mult #449

merged 7 commits into from
Dec 11, 2020

Commits on Nov 24, 2020

  1. add test case for OccupiedEntry::remove_entry_mult 

    This is just a self contained test case, currently reproducing the
panic of hyperium#446.
    @dekellum
    dekellum committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    19e82f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. expand test cases for remove_entry_mult

    @dekellum
    dekellum committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    ad54c55 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. add multiple remove_entry_mult call tests to show more issues

    @dekellum
    dekellum committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5575c13 View commit details
    Browse the repository at this point in the history

  2. test repeated HeaderMap::remove for comparison

    @dekellum
    dekellum committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    2c247d0 View commit details
    Browse the repository at this point in the history

  3. tests showing similar problem with remove_entry on extra values

    @dekellum
    dekellum committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    e419939 View commit details
    Browse the repository at this point in the history

  4. fix remove_entry by moving remove_found after remove_all_extra_values

    @dekellum
    dekellum committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9f6a750 View commit details
    Browse the repository at this point in the history

  5. fix remove_entry_mult by eager collection of extras before remove_found 

    In order to remove extra values prior to remove_found, we must collect
them eagerly. Eager collection is based on:

    commit 8ffe094
    Author:     Sean McArthur <sean@seanmonstar.com>
    AuthorDate: Mon Nov 25 17:34:30 2019 -0800
    Commit:     Sean McArthur <sean@seanmonstar.com>
    CommitDate: Tue Nov 26 10:03:09 2019 -0800

	Make ValueDrain eagerly collect its extra values

...which was reverted in 6c2b789.
    @dekellum
    dekellum committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    27d993c View commit details
    Browse the repository at this point in the history