-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile errors at hyper-0.13.5/src/server/conn.rs:926:21 and hyper-0.13.5/src/server/shutdown.rs:65:17 #2199
Comments
Is this a nightly version of |
No, it's current stable:
Here's the test-setup on Github as well: |
Maybe due to pin-project v0.4.11 changes? https://github.com/taiki-e/pin-project/releases/tag/v0.4.11 |
@taiki-e do you know if this is a regression, or something else? |
provisional measures soultion: ...
[dependencies]
pin-project = "=0.4.10"
... |
@seanmonstar This is a regression of pin-project (sorry!). I yanked 0.4.11 (that has this regression) and released 0.4.12 based on 0.4.10. (It should be fixed by updating Cargo.lock: |
Wow, thanks for the quick triage and fix! Confirmed the issue is resolved now, thanks!
|
207: Do not skip visiting nested expressions r=taiki-e a=taiki-e Fixes #206 and hyperium/hyper#2199 Co-authored-by: Taiki Endo <te316e89@gmail.com>
Thanks @taiki-e! |
Tests on my project, Goose, just started failing. Locally I ran a
cargo update
and now can duplicate. Hyper was not updated, and yet it's where the failures are happening. Please see below:The text was updated successfully, but these errors were encountered: