Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove server http2 Builder::with_executor method #3087

Closed
seanmonstar opened this issue Dec 16, 2022 · 0 comments · Fixed by #3089
Closed

Remove server http2 Builder::with_executor method #3087

seanmonstar opened this issue Dec 16, 2022 · 0 comments · Fixed by #3089
Labels
A-server Area: server. B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC2

Comments

@seanmonstar
Copy link
Member

The with_executor method is no longer needed, since the executor is set via Builder::new(exec).
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. B-breaking-change Blocked: this is an "API breaking change". labels Dec 16, 2022
@seanmonstar seanmonstar added this to the 1.0 RC2 milestone Dec 16, 2022
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Dec 16, 2022
MrGunflame added a commit to MrGunflame/hyper that referenced this issue Dec 17, 2022
@MrGunflame
feat(server): remove http2::Builder::with_executor
7b04749 
removes the Builder::with_executor method as it is already
provided in Builder::new

Closes hyperium#3087

BREAKING CHANGE: removes Builder::with_executor
@MrGunflame MrGunflame mentioned this issue Dec 17, 2022
Merged
seanmonstar pushed a commit that referenced this issue Dec 19, 2022
@MrGunflame
feat(server): remove server::conn::http2::Builder::with_executor() (#…
ab59a6f 
…3089)

removes the Builder::with_executor method as it is already
provided in Builder::new

Closes #3087

BREAKING CHANGE: removes `server::conn::http2::Builder::with_executor()`
Repository owner moved this from Todo to Done in hyper 1.0 Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC2
Development

Successfully merging a pull request may close this issue.

Remove server::http2::Builder::with_executor MrGunflame/hyper
1 participant
@seanmonstar