Support requets to domain names in example http_server #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Stringauthority will be converted toSocketAddr(https://docs.rs/tokio/1.5.0/tokio/net/trait.ToSocketAddrs.html) via under-the-hood DNS lookups. The proxy only needs to check whether the authority part exists (the uri is an absolute uri) to support requests to domain names. This would make the example even more useful.Another change I packed into this PR is to slightly simplify the
tunnelmethod usingtokio::io::copy_bidirectional. I'm open for objections if this introduces some side effects that I'm unware of.