Expose http09 and http1 options on low-level client connection builders. #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client connection builders. These options are currently available on the high-level builder only. Along the way, rename the setters to follow the public API conventions and add docs. Closes hyperium#2461
seanmonstar
approved these changes
Aug 4, 2021
|
It looks like some tests are failing for (I think?) unrelated reasons. The trailing semicolon issue on nightly seems to stem from rust-lang/rust#87385 I don't know enough about the |
|
Ah, ok, got #2612 in to fix those errors. Wanna rebase? |
|
Passing now, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are currently available on the high-level builder only.
Along the way, rename the setters to follow the public API conventions and add docs.
Closes #2461