Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.14 backport chunked fixes #3496

Merged
merged 2 commits into from
Dec 18, 2023
Merged

0.14 backport chunked fixes #3496

merged 2 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. fix(http1): reject chunked headers missing a digit (#3494) 

    Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
    @seanmonstar
    seanmonstar committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    216f212 View commit details
    Browse the repository at this point in the history

  2. fix(http1): add internal limit for chunked extensions (#3495) 

    The chunked transfer-encoding allows for extensions within the header of
each chunk. hyper currently ignores the extension bytes. Sending large
amounts of bytes in the extensions will waste CPU reaing and skipping
them.

This change adds an internal limit to how many bytes will be read and
ignored in a single body, before returning an error.

Reported-by: Bartek Nowotarski <bartek@nowotarski.info>
    @seanmonstar
    seanmonstar committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e1e2aa3 View commit details
    Browse the repository at this point in the history