Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use share data in service #3503

Merged
merged 1 commit into from
Dec 26, 2023
Merged

use share data in service #3503

merged 1 commit into from
Dec 26, 2023

Conversation

getong
Copy link
Contributor

@getong getong commented Dec 25, 2023 •
edited
Loading

fix two issues here

  • all connections share the same data here, not one state per connection .
  • when uri not found, the couter does not add one.

seanmonstar
seanmonstar approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and sending a fix!

@seanmonstar seanmonstar enabled auto-merge (squash) December 26, 2023 00:05
@seanmonstar seanmonstar merged commit 26f8675 into hyperium:master Dec 26, 2023
21 checks passed
@getong getong deleted the use_share_data_in_service branch December 26, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getong @seanmonstar