Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.6.0: unannounced MSRV break #843

Closed
Kixunil opened this issue Nov 20, 2021 · 1 comment · Fixed by #847
Closed

0.6.0: unannounced MSRV break #843

Kixunil opened this issue Nov 20, 2021 · 1 comment · Fixed by #847
Milestone
0.7

Comments

@Kixunil
Copy link

Kixunil commented Nov 20, 2021

0.6.0 broke MSRV which isn't listed in changelog as breaking change. Is this intended?

I'd also like to ask if edition bump can be reverted so that Rust version 1.48.0 is supported - this is the version currently in Debian Stable.
@davidpdrsn
Copy link
Member

Yep we already agreed to go back to 2018 for the next release!

@davidpdrsn davidpdrsn added this to the 0.7 milestone Nov 20, 2021
davidpdrsn added a commit that referenced this issue Nov 25, 2021
@davidpdrsn
chore: revert to 2018 edition
754403c 
Fixes #843
@davidpdrsn davidpdrsn mentioned this issue Nov 25, 2021
Merged
Guiguiprim pushed a commit to JustRustThings/tonic that referenced this issue Nov 30, 2021
@davidpdrsn
chore: revert to 2018 edition
54ad1e7 
Fixes hyperium#843
davidpdrsn added a commit that referenced this issue Dec 7, 2021
@davidpdrsn
chore: revert to 2018 edition (#847)
101f2f7 
Fixes #843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

chore: revert to 2018 edition hyperium/tonic
2 participants
@davidpdrsn @Kixunil