chore: wrong path for call to compile_protos
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed wrong path "proto/helloworld.proto" for `compile_protos` first argument. `build.rs` being in the project root, means the correct path should be "src/proto/helloworld.proto".
LucioFranco
changed the title
compile_protoscompile_protos
nicklaw5
added a commit
to nicklaw5/tonic
that referenced
this pull request
Jun 7, 2020
This change reverts hyperium#366. The `proto/` directory, as described in the guide, is created under the root of the crate. Not under `src/`. I've also included a fix to the `grpcurl` endpoint.
LucioFranco
pushed a commit
that referenced
this pull request
Jun 9, 2020
This change reverts #366. The `proto/` directory, as described in the guide, is created under the root of the crate. Not under `src/`. I've also included a fix to the `grpcurl` endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong path "proto/helloworld.proto" for
compile_protosfirst argument.build.rsbeing in the project root, means the correct path should be "src/proto/helloworld.proto".