Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos RPC fallback provider #3425

Closed
Tracked by #3321
tkporter opened this issue Mar 15, 2024 · 6 comments · Fixed by #4752
Closed
Tracked by #3321

Cosmos RPC fallback provider #3425

tkporter opened this issue Mar 15, 2024 · 6 comments · Fixed by #4752
Labels
agent cosmos extra-small bounty size operations

Comments

@tkporter
Copy link
Collaborator

Problem

  • On Comsos, we just have the fallback provider implemented for GRPC
  • We use RPC for e.g. requesting block data in block-by-block indexing, so RPC is pretty critical

Solution

  • Implement fallback provider for Cosmos RPC
@tkporter tkporter mentioned this issue Mar 15, 2024
Open
@avious00
Copy link
Contributor

hey @tkporter is this a different fallback from https://github.com/hyperlane-xyz/issues/issues/892

@tkporter
Copy link
Collaborator Author

Yeah that one was done just for the GRPC provider but not for the RPC provider (sadly we require RPC and GRPC for cosmos). So this tracks the RPC one

@tkporter tkporter moved this to Sprint in Hyperlane Tasks Jul 19, 2024
@tkporter
Copy link
Collaborator Author

Recent motivating incident https://www.notion.so/hyperlanexyz/Neutron-indexing-outage-6eb3ad137337411c8329595a47e86147#8a5ae8509bdc4dad9b5af5495fb0b937

@antonr-p2p
Copy link

We face this issue from time to time for Neutron network, depending on frequency of Neutron validators upgrades. Last months there were few Neutron network outages that lead to Hyperlane validator stucking due to missing of proper failover to other RPC nodes.

@daniel-savu daniel-savu added the extra-small bounty size label Oct 16, 2024
@Mantas-M Mantas-M mentioned this issue Oct 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@Mantas-M
feat: Cosmos RPC client supporting fallback rpcs (#4752)
8ff194d 
### Description

Added fallback functionality to the Cosmos RPC client

### Drive-by changes

N/A

### Related issues

- Fixes #3425

### Backward compatibility

Yes

### Testing

Unit tests already in place, no additional added, as the generic
CosmosFallbackProvider which is used is already tested
@github-project-automation github-project-automation bot moved this from Sprint to Done in Hyperlane Tasks Oct 29, 2024
@antonr-p2p
Copy link

antonr-p2p commented Oct 29, 2024 •
edited
Loading

Cool! Thanks! Would wait for the new build to upgrade to!

@daniel-savu
Copy link
Contributor

Cool! Thanks! Would wait for the new build to upgrade to!

@antonr-p2p you're free to upgrade, we're also trying to move to versioned releases and this will be included in the next one (agents-1.1.0) that should go live by end of week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent cosmos extra-small bounty size operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Cosmos RPC client supporting fallback rpcs Mantas-M/hyperlane-monorepo
4 participants
@tkporter @daniel-savu @avious00 @antonr-p2p