-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraper sealevel support: fully implement HyperlaneProvider
for SealevelProvider
#4272
Open
Tracked by
#4271
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 24, 2024
…4727) ### Description Make HyperlaneProvider to request block by height, not by hash. Since it is hard to find a block by hash for Solana, we switch to use block height. We have to do it for all type of chains since we need to change signature of chain-agnostic method ### Drive-by changes * Small method rename ### Related issues - Contributes into #4272 ### Backward compatibility Yes ### Testing Manual run of Scraper for Ethereum and Neutron chains. --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this issue
Oct 25, 2024
…yperlane-xyz#4727) ### Description Make HyperlaneProvider to request block by height, not by hash. Since it is hard to find a block by hash for Solana, we switch to use block height. We have to do it for all type of chains since we need to change signature of chain-agnostic method ### Drive-by changes * Small method rename ### Related issues - Contributes into hyperlane-xyz#4272 ### Backward compatibility Yes ### Testing Manual run of Scraper for Ethereum and Neutron chains. --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this issue
Oct 25, 2024
…yperlane-xyz#4727) ### Description Make HyperlaneProvider to request block by height, not by hash. Since it is hard to find a block by hash for Solana, we switch to use block height. We have to do it for all type of chains since we need to change signature of chain-agnostic method ### Drive-by changes * Small method rename ### Related issues - Contributes into hyperlane-xyz#4272 ### Backward compatibility Yes ### Testing Manual run of Scraper for Ethereum and Neutron chains. --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this issue
Oct 25, 2024
…yperlane-xyz#4727) ### Description Make HyperlaneProvider to request block by height, not by hash. Since it is hard to find a block by hash for Solana, we switch to use block height. We have to do it for all type of chains since we need to change signature of chain-agnostic method ### Drive-by changes * Small method rename ### Related issues - Contributes into hyperlane-xyz#4272 ### Backward compatibility Yes ### Testing Manual run of Scraper for Ethereum and Neutron chains. --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this issue
Oct 25, 2024
…yperlane-xyz#4727) ### Description Make HyperlaneProvider to request block by height, not by hash. Since it is hard to find a block by hash for Solana, we switch to use block height. We have to do it for all type of chains since we need to change signature of chain-agnostic method ### Drive-by changes * Small method rename ### Related issues - Contributes into hyperlane-xyz#4272 ### Backward compatibility Yes ### Testing Manual run of Scraper for Ethereum and Neutron chains. --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 30, 2024
### Description Scraper is able to index dispatch messages: 1. Blocks are stored into database 2. Transactions are stored into database (need population of all fields) 3. Dispatched messages are stored into database ### Drive-by changes Initial indexing of delivered messages (so that Scraper does not crush) ### Related issues - Contributes into #4272 ### Backward compatibility Yes (Solana-like chains should not be enabled for Scraper) ### Testing Manual run of Scraper E2E Tests --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 5, 2024
### Description Scraper populates transaction fields for Solana ### Related issues - Contributes into #4272 ### Backward compatibility Yes (configuration is updated) ### Testing Manual test of Scraper Run E2E tests for Ethereum and Solana --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 8, 2024
#4813) ### Description Scraper reports mailbox as recipient of transactions for Sealevel ### Related issues - Contributes into #4272 ### Backward compatibility Yes ### Testing Manual test of Scraper E2E tests for Ethereum and Sealevel --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 11, 2024
### Description Scraper populates gas payments for Sealevel ### Related issues - Contributes into #4272 ### Backward compatibility Yes ### Testing Manual run of Scraper --------- Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
impl HyperlaneProvider for SealevelProvider
, which atm has a bunch oftodo!()
s because those paths aren't used by the relayer or validator:hyperlane-monorepo/rust/chains/hyperlane-sealevel/src/provider.rs
Line 63 in cf6816b
This will be more thoroughly tested by subsequent work in e2e #4273. I'd say the success criteria here can be a bit looser with the understanding that any bugs here will have an impact on 4273, and we can use 4273 as the way to test the changes here
The text was updated successfully, but these errors were encountered: