Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer balance metrics #2976

Merged
merged 24 commits into from
Dec 5, 2023
Merged

Relayer balance metrics #2976

merged 24 commits into from
Dec 5, 2023

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Nov 24, 2023

Done:

  • scaffolding for fetching custom agent metrics
  • abstractions for building a metrics fetcher for a given VM
  • querying cosmos balances; e2e tested.
  • querying evm balances; e2e tested.
    • Note that as a result, evm addresses are now no longer zero-padded when printed in the logs. This may break existing log queries
  • fixed a nasty bug on ubuntu where wasmd (osmosisd dependency, part of the grpc query flow) would panic when a block is specified via x-cosmos-block-height. The fix was to bump the version of osmosisd from 19.0.0 to 20.5.0. Note that when running e2e on Mac OS, the osmosis version in use is still 19.0.0. That's because we need a fork that publishes a darwin target binary (currently pointing here)

For follow up PR:

  • sealevel balance querying

I'm open to all renaming suggestions, I just tried to speed through and didn't ponder names too much

Relates to https://github.com/hyperlane-xyz/issues/issues/701
Closes https://github.com/hyperlane-xyz/issues/issues/702 (because the balance becomes available in the metrics endpoint for polling)

Copy link

changeset-bot bot commented Nov 24, 2023

⚠️ No Changeset found

Latest commit: 2b4ae36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daniel-savu daniel-savu force-pushed the dan/relayer-balance-metrics branch from 9e81247 to cf5b5ec Compare November 27, 2023 22:16
@daniel-savu daniel-savu force-pushed the dan/relayer-balance-metrics branch from cf5b5ec to 30323f1 Compare November 27, 2023 23:45
@daniel-savu daniel-savu marked this pull request as ready for review November 28, 2023 01:26
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some questions about how the abstractions are set up

rust/hyperlane-core/src/metrics/agent.rs Outdated Show resolved Hide resolved
rust/hyperlane-core/src/metrics/agent.rs Outdated Show resolved Hide resolved
rust/agents/relayer/src/relayer.rs Outdated Show resolved Hide resolved
rust/agents/scraper/migration/bin/common.rs Show resolved Hide resolved
rust/chains/hyperlane-cosmos/src/providers/mod.rs Outdated Show resolved Hide resolved
rust/ethers-prometheus/src/middleware/mod.rs Outdated Show resolved Hide resolved
rust/hyperlane-base/src/metrics/agent_metrics.rs Outdated Show resolved Hide resolved
rust/utils/run-locally/src/cosmos/mod.rs Show resolved Hide resolved
rust/chains/hyperlane-cosmos/src/providers/grpc.rs Outdated Show resolved Hide resolved
rust/hyperlane-base/src/metrics/agent_metrics.rs Outdated Show resolved Hide resolved
@daniel-savu daniel-savu enabled auto-merge (squash) December 5, 2023 11:10
@daniel-savu daniel-savu merged commit 77aa58c into main Dec 5, 2023
10 of 16 checks passed
@daniel-savu daniel-savu deleted the dan/relayer-balance-metrics branch December 5, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants