-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:enable DefaultFallbackRoutingIsm
through non-factory deployment
#3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
requested review from
tkporter,
nambrot,
jmrossy and
yorhodes
as code owners
December 1, 2023 05:42
🦋 Changeset detectedLatest commit: 8b05186 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yorhodes
reviewed
Dec 1, 2023
jmrossy
reviewed
Dec 1, 2023
jmrossy
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks but mostly lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DefaultFallbackRoutingIsm
needs the mailbox address which meantDefaultFallbackRoutingIsmFactory
needed the mailbox address which is not ideal. So, I switched to non-factory deployments for this specific ISM type.cachedAddresses
to store the latest ie toplevel ISM.Drive-by changes
ismFactory.fromAddressMap
to not use the multiprovider filtered by contract map. This is undesirable as CLI user can provide chain selection and artifacts which doesn't include all the chains in the configs (and when we callmultiprovider.getDomainId
for the origin which may now be missing from the filtered MP, we get an error).Related issues
Backward compatibility
Yes
Testing
Manual through CLI