-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gas escalator middleware #4211
base: main
Are you sure you want to change the base?
Conversation
…yz/hyperlane-monorepo into dan/gas-escalator-middleware
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
==========================================
+ Coverage 74.58% 74.60% +0.01%
==========================================
Files 103 103
Lines 1515 1516 +1
Branches 195 195
==========================================
+ Hits 1130 1131 +1
Misses 364 364
Partials 21 21
|
Description
Follow up to #3852 and #4098.
Since each escalator instance spawns a thread and we create transient providers for each message, this created a memory leak of escalator tasks that would build up over time - on RC, memory usage had reached 27gb before we noticed.
This PR merges in the changes from #4208 to stop the leak.
Memory profile before the fix (62mb peak usage):
Memory profile after the fix (16mb peak usage):
Drive-by changes
Related issues
Backward compatibility
Testing