Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve reliability of hook indexing #4214

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Jul 29, 2024

Description

After deploying this, should no longer see logs like https://cloudlogging.app.goo.gl/gK4ByT1qLXTG7VN19

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 21e2140

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daniel-savu daniel-savu changed the title improve reliability of hook indexing WIP: improve reliability of hook indexing Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (968160f) to head (21e2140).
Report is 100 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4214   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         14      14           
=====================================
  Misses        14      14           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@daniel-savu daniel-savu changed the title WIP: improve reliability of hook indexing fix: improve reliability of hook indexing Jul 30, 2024
@daniel-savu daniel-savu added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 38a52de Aug 27, 2024
34 of 39 checks passed
@daniel-savu daniel-savu deleted the dan/no-receipt-indexing-fix branch August 27, 2024 13:46
@tkporter tkporter mentioned this pull request Aug 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
### Description

- deployed to include #4214 
- some drive-bys, e.g. one flaky AWS interaction, and to use a non-zero
exit code if there's an error deploying agents

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hook indexing may miss event if the receipt is missing
2 participants