-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GCS folder support #4652
fix: GCS folder support #4652
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 101 101
Lines 1481 1481
Branches 192 192
=======================================
Hits 1100 1100
Misses 360 360
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, so the TL;DR is that GCS has no notion of folders and you just prepend it to the object key?
GCS does have folders, but the existing code for GCS doesn't work with them correctly. That's why @IvanPsurtcev has made this addition to support folders like they are for AWS. This is actually quite essential, because running multiple validators on one bucket requires them using different folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
@IvanPsurtcev I think merging |
…dded upload_and_log function
Head branch was pushed to by a user without write access
9eec954
to
e543e26
Compare
@daniel-savu Done |
21a0cf9
Description
This PR fixes the problem of this issue:
https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4449
The change was only in the gcs_storage.rs file. Slightly tweaked methods so that you can write files to a specified folder in the terminal.
When trying to run a validator specifying checkpointSyncer settings for GCS:
--checkpointSyncer.type gcs --checkpointSyncer.bucket an-s3-signatures-repository --checkpointSyncer.folder atletaolympia
To solve this problem I added the
folder: Option<String>
field to the GcsStorageClient structure, I also added bucket and folder processing to the impl CheckpointSyncer, GcsStorageClientBuilder methods