fix: isObject utils fn should return only boolean value #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a9c0b32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4756 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 101 101
Lines 1460 1460
Branches 191 191
=======================================
Hits 1080 1080
Misses 359 359
Partials 21 21
|
Merged
via the queue into
hyperlane-xyz:main
with commit Oct 25, 2024
a36fc5f
28 of 32 checks passed
paulbalaji
pushed a commit
that referenced
this pull request
Oct 29, 2024
### Description
When `isObject` pass with param `null/undefined` it returns
`null/undefined`
We should strict return boolean value
<!--
What's included in this PR?
-->
### Drive-by changes
```diff
export function isObject(item: any): boolean {
- return item && typeof item === 'object' && !Array.isArray(item);
+ return !!item && typeof item === 'object' && !Array.isArray(item);
}
```
<!--
Are there any minor or drive-by changes also included?
-->
### Related issues
<!--
- Fixes #[issue number here]
-->
### Backward compatibility
<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?
Yes/No
-->
### Testing
Has updated with test `object.test.ts`
<!--
What kind of testing have these changes undergone?
None/Manual/Unit Tests
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
isObjectpass with paramnull/undefinedit returnsnull/undefinedWe should strict return boolean value
Drive-by changes
export function isObject(item: any): boolean { - return item && typeof item === 'object' && !Array.isArray(item); + return !!item && typeof item === 'object' && !Array.isArray(item); }Related issues
Backward compatibility
Testing
Has updated with test
object.test.ts