feat: do not exhaustively derive routing config in TS relayer #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 86aa19b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4765 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 101 101
Lines 1460 1460
Branches 191 191
=======================================
Hits 1080 1080
Misses 359 359
Partials 21 21
|
yorhodes
changed the title
yorhodes
changed the title
xeno097
reviewed
Oct 25, 2024
ltyu
reviewed
Oct 25, 2024
xeno097
approved these changes
Oct 28, 2024
paulbalaji
pushed a commit
that referenced
this pull request
Oct 29, 2024
### Description CLI commands using HyperlaneRelayer (`--relay`) were very slow due to exhaustive routing ISM/hook derivation. This short-circuits the derivation when there is a known "message context" to evaluate the routing hook and ISMs for. ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility Yes ### Testing Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLI commands using HyperlaneRelayer (
--relay) were very slow due to exhaustive routing ISM/hook derivation. This short-circuits the derivation when there is a known "message context" to evaluate the routing hook and ISMs for.Related issues
Backward compatibility
Yes
Testing
Manual