Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ism.route(message) for supporting self relay of ICA ISM #4772

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Oct 28, 2024

Description

ICA ISM does not implement module(uint32) but rather route(message). This modifies ISM derivation with message context to use this function.

Related issues

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: a95c2dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yorhodes yorhodes changed the title Use ism.route(message) for supporting self relay of ICA ISM fix: use ism.route(message) for supporting self relay of ICA ISM Oct 28, 2024
@yorhodes yorhodes added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 56328e6 Oct 28, 2024
25 of 27 checks passed
@yorhodes yorhodes deleted the self-relay-ica-ism branch October 28, 2024 21:19
paulbalaji pushed a commit that referenced this pull request Oct 29, 2024
…4772)

### Description

ICA ISM does not implement `module(uint32)` but rather `route(message)`.
This modifies ISM derivation with message context to use this function.

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

Yes

### Testing

Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants