Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add taint & toleration to mainnet3 relayer node pool #4780

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Oct 29, 2024

Description

See https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/

  • In GKE, for the larger relayer node pool, added a taint: NoSchedule, label component=relayer
  • In our relayer workloads, they now have a toleration that matches that taint
  • As part of rollout, first did a NoExecute (evicting everything on the big nodes), then moved to NoSchedule (so that some other pods like daemonsets would still get onto these bigger nodes). I made sure the hyperlane and neutron context relayers have these tolerations

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (83a1567) to head (1e7e54d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4780   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         101      101           
  Lines        1466     1466           
  Branches      191      191           
=======================================
  Hits         1085     1085           
  Misses        360      360           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 76.41% <ø> (ø)
isms 77.58% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tkporter tkporter added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@paulbalaji paulbalaji added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@paulbalaji paulbalaji added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit fc3818d Oct 30, 2024
36 checks passed
@paulbalaji paulbalaji deleted the trevor/relayer-taint-toleration branch October 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants