This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Add option to EDV REST provider to get full document on query #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
- Coverage 89.59% 89.58% -0.02%
==========================================
Files 221 221
Lines 15578 15619 +41
==========================================
+ Hits 13957 13992 +35
- Misses 956 959 +3
- Partials 665 668 +3
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
EDVRESTProviderOptionToGetFullDocOnQuery
branch
from
9aae94f to
c3d5a92
Compare
DRK3
force-pushed
the
EDVRESTProviderOptionToGetFullDocOnQuery
branch
2 times, most recently
from
e20b614 to
240ec33
Compare
baha-ai
approved these changes
Nov 29, 2020
fqutishat
reviewed
Nov 29, 2020
pkg/storage/edv/restprovider.go
Outdated
| func NewRESTProvider(edvServerURL, vaultID string, | ||
| macCrypto *MACCrypto, httpClientOpts ...Option) (*RESTProvider, error) { | ||
| macCrypto *MACCrypto, returnFullDocumentsOnQuery bool, httpClientOpts ...Option) (*RESTProvider, error) { |
- Added an option to enable a performance optimization that can be enabled if being used with an EDV server that supports it. - Removed a comment with a ToDo regarding dealing with a potential edge-case issue since I've now realized that the design of the EDV provider already prevents it from happening in the first place. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
EDVRESTProviderOptionToGetFullDocOnQuery
branch
from
240ec33 to
ebb3c3c
Compare
fqutishat
approved these changes
Nov 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Trider Derek.Trider@securekey.com