Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

docs: Presentation Exchange - adds samples #2437

Merged
merged 1 commit into from
Jan 8, 2021
Merged

docs: Presentation Exchange - adds samples #2437

merged 1 commit into from
Jan 8, 2021

Conversation

soluchok
Copy link
Contributor

@soluchok soluchok commented Jan 8, 2021

Adds Presentation Exchange samples.

Signed-off-by: Andrii Soluk isoluchok@gmail.com

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #2437 (226502b) into master (b23388a) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2437   +/-   ##
=======================================
  Coverage   89.57%   89.58%           
=======================================
  Files         246      246           
  Lines       17674    17688   +14     
=======================================
+ Hits        15832    15845   +13     
- Misses       1083     1084    +1     
  Partials      759      759           
Impacted Files Coverage Δ
pkg/doc/presexch/definition.go 90.13% <93.75%> (+0.13%) ⬆️
pkg/doc/verifiable/credential.go 89.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23388a...226502b. Read the comment docs.

@soluchok soluchok changed the title docs: Presentation Exchange - adds samples WIP: docs: Presentation Exchange - adds samples Jan 8, 2021
@soluchok soluchok changed the title WIP: docs: Presentation Exchange - adds samples docs: Presentation Exchange - adds samples Jan 8, 2021
@soluchok soluchok self-assigned this Jan 8, 2021
@soluchok soluchok added this to the v0.1.6 milestone Jan 8, 2021
Signed-off-by: Andrii Soluk <isoluchok@gmail.com>
@troyronda troyronda merged commit b423cb5 into hyperledger-archives:master Jan 8, 2021
"@context": [
"https://www.w3.org/2018/credentials/v1"
],
"age": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soluchok

This is a different claim than the one originally issued (by the Issuer). This new claim is not covered by cryptographic proof from the Issuer; it is unverifiable.

How will this work in practice?

1. This example demonstrates `predicate` and `limit_disclosure` usage.
The `presentation definition` below requires field `age` to be greater or equal to 18.
Also, we have `limit_disclosure=true` which requires that output data is limited to the entries specified in the `fields` property.
The `predicate` means that the result should be expressed as a boolean value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soluchok

The predicate means that the result should be expressed as a boolean value.

This is a misunderstanding of the spec. The predicate is just criteria that the credential submitted in the presentation must satisfy. It is not a transformation function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants