Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: Pass VC Test Suite where JWS is passed as input data #981

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

kdimak
Copy link
Contributor

@kdimak kdimak commented Dec 16, 2019

closes #947

Signed-off-by: Dima dkinoshenko@gmail.com

A number of VC Test Suite failures:

  • Before: 14
  • After: 2

A PR is made to enhance VC Test suite input data: w3c/vc-test-suite#102

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #981 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files          90       90           
  Lines        5788     5788           
=======================================
  Hits         5262     5262           
  Misses        285      285           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da989c...d1cfbf6. Read the comment docs.

Copy link
Contributor

@troyronda troyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to revisit the patched test cases.

@troyronda troyronda merged commit 44979b6 into hyperledger-archives:master Dec 18, 2019
@llorllale
Copy link
Contributor

We will need to revisit the patched test cases.

Indeed. I saw unanswered questions in the VC testsuite repo (eg. "what key was used to sign in this test?")

@kdimak kdimak deleted the issue-947 branch December 19, 2019 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Pass VC Test Suite
3 participants