Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use tools/ci.sh in Github Actions #497

Closed
petermetz opened this issue Jan 15, 2021 · 1 comment · Fixed by #715
Closed

ci: use tools/ci.sh in Github Actions #497

petermetz opened this issue Jan 15, 2021 · 1 comment · Fixed by #715
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file dependent Developer_Experience good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Milestone

Comments

@petermetz
Copy link
Contributor

Depends on #496

Describe the bug

Currently the Github Action only runs a subset of the complete CI, for example the front-end components are not being compiled.

To Reproduce

Read the ci.yml file's contents in the .github directory of the project.

Expected behavior

Github actions runs the full CI suite so we catch all errors.

Logs/Stack traces

N/A

Screenshots

N/A

Cloud provider or hardware configuration:

N/A

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

Hyperledger Cactus Plugins/Connectors Used

All of them.

Additional context

N/A

cc: @sfuji822 @takeutak @hartm @jonathan-m-hamilton

@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers dependencies Pull requests that update a dependency file Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Jan 15, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 15, 2021
@github-actions
Copy link

⏳ Alright! Looks like we need to wait for some dependencies:

💡 Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

petermetz added a commit to petermetz/cacti that referenced this issue Mar 24, 2021
While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Fixes hyperledger-cacti#497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz self-assigned this Mar 24, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 26, 2021
While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Fixes hyperledger-cacti#497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 30, 2021
Primary change
=============

While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Secondary change
================

Add retries to the tests to minimize the amount of failures
due to flake where manual intervention is needed (e.g. manually
restarting the tests after a false negative).
This will also not make the false negatives go away 100% but
the hope is that it will reduce them in numbers and therefore
make it a little less annoying for contributors who send PRs.

Fixes hyperledger-cacti#497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 30, 2021
Primary change
=============

While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Secondary change
================

Add retries to the tests to minimize the amount of failures
due to flake where manual intervention is needed (e.g. manually
restarting the tests after a false negative).
This will also not make the false negatives go away 100% but
the hope is that it will reduce them in numbers and therefore
make it a little less annoying for contributors who send PRs.

Fixes hyperledger-cacti#497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Mar 30, 2021
Primary change
=============

While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Secondary change
================

Add retries to the tests to minimize the amount of failures
due to flake where manual intervention is needed (e.g. manually
restarting the tests after a false negative).
This will also not make the false negatives go away 100% but
the hope is that it will reduce them in numbers and therefore
make it a little less annoying for contributors who send PRs.

Fixes #497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
Primary change
=============

While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.

Secondary change
================

Add retries to the tests to minimize the amount of failures
due to flake where manual intervention is needed (e.g. manually
restarting the tests after a false negative).
This will also not make the false negatives go away 100% but
the hope is that it will reduce them in numbers and therefore
make it a little less annoying for contributors who send PRs.

Fixes hyperledger-cacti#497

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file dependent Developer_Experience good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant