Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-aws-sm): complete request handler and endpoints #1153

Merged
merged 2 commits into from
Oct 8, 2021
Merged

feat(keychain-aws-sm): complete request handler and endpoints #1153

merged 2 commits into from
Oct 8, 2021

Conversation

Leeyoungone
Copy link
Contributor

@Leeyoungone Leeyoungone commented Jul 20, 2021 •
edited
Loading

Depends on #1349

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch from c5ac52d to 47d8dd1 Compare July 21, 2021 18:12
@Leeyoungone Leeyoungone changed the title Feat 967 complete request handler and endpoints feat(keychain-aws-sm): complete request handler and endpoints Jul 21, 2021
@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 5 times, most recently from 4f99fc3 to 455b47d Compare July 26, 2021 18:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #1153 (91c432a) into main (d016678) will increase coverage by 0.22%.
The diff coverage is 83.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   71.35%   71.57%   +0.22%     
==========================================
  Files         308      317       +9     
  Lines       11264    11569     +305     
  Branches     1383     1418      +35     
==========================================
+ Hits         8037     8281     +244     
- Misses       2473     2512      +39     
- Partials      754      776      +22
Impacted Files Coverage Δ
...ript/webservices/get-keychain-entry-endpoint-v1.ts 80.55% <73.91%> (ø)
...ript/webservices/set-keychain-entry-endpoint-v1.ts 84.84% <80.00%> (ø)
...pescript/generated/openapi/typescript-axios/api.ts 84.09% <83.33%> (ø)
...t/webservices/delete-keychain-entry-endpoint-v1.ts 84.84% <84.84%> (ø)
...ript/webservices/has-keychain-entry-endpoint-v1.ts 86.11% <86.11%> (ø)
...-sm/src/main/typescript/plugin-factory-keychain.ts 100.00% <100.00%> (+33.33%) ⬆️
...s-sm/src/main/typescript/plugin-keychain-aws-sm.ts 76.23% <100.00%> (+7.16%) ⬆️
...-keychain-aws-sm/src/main/typescript/public-api.ts 85.71% <100.00%> (ø)
...cript/generated/openapi/typescript-axios/common.ts 43.47% <0.00%> (ø)
...script/generated/openapi/typescript-axios/index.ts 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d016678...91c432a. Read the comment docs.

@Leeyoungone Leeyoungone marked this pull request as ready for review July 27, 2021 13:54
petermetz
petermetz requested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leeyoungone Please include in the description of the PR the depends on #??? syntax to mark it as dependent on the parent PR with the keychain. This cannot be merged before that one and this is the way to ensure human error won't happen in this regard.

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 5 times, most recently from 419d23a to d51cb8d Compare July 30, 2021 16:07
@petermetz
Copy link
Contributor

@Leeyoungone I found this in the CI logs, basically saying that the coverage has been reduced compared to how it was below so if you raise it a bit that will hopefully appease the CI.
Here's the report for reference (you can identify which exact lines are covered/uncovered in which exact files. I recommend only looking at the ones that you touched the code of / modified the tests of.

2021-07-30T18:40:06.3622167Z ERROR: Coverage for branches (44.97%) does not meet global threshold (45%)
2021-07-30T18:40:09.0850617Z ---------------------------------------|---------|----------|---------|---------|-------------------
2021-07-30T18:40:09.0853236Z File                                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
2021-07-30T18:40:09.0855370Z ---------------------------------------|---------|----------|---------|---------|-------------------
2021-07-30T18:40:09.0876041Z All files                              |   78.64 |    44.97 |   71.16 |   78.61 |                   
2021-07-30T18:40:09.0877776Z  cactus-api-client/src/main/typescript |   98.36 |    77.78 |     100 |   98.31 |                   
2021-07-30T18:40:09.0879325Z   api-client.ts                        |   96.67 |       75 |     100 |   96.67 | 119               
2021-07-30T18:40:09.0880839Z   default-consortium-provider.ts       |     100 |       80 |     100 |     100 | 67                
2021-07-30T18:40:09.0883544Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.0886396Z   public-api.ts                        |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.0895457Z  ...cmd-api-server/src/main/typescript |   90.68 |    73.02 |   81.03 |   90.68 |                   
2021-07-30T18:40:09.0900061Z   api-server.ts                        |   89.97 |    73.02 |   85.11 |   90.17 | ...83-394,619-622 
2021-07-30T18:40:09.0901764Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.0912519Z   public-api.ts                        |     100 |      100 |   63.64 |     100 |                   
2021-07-30T18:40:09.0922770Z  ...ver/src/main/typescript/api-client |      96 |    76.92 |   90.91 |      96 |                   
2021-07-30T18:40:09.0932318Z   api-server-api-client.ts             |      96 |    76.92 |   90.91 |      96 | 90-92             
2021-07-30T18:40:09.0952367Z  ...-server/src/main/typescript/authzn |   92.41 |    73.68 |     100 |   92.31 |                   
2021-07-30T18:40:09.0963315Z   authorizer-factory.ts                |   92.11 |    66.67 |     100 |      92 | ...30-134,141,165 
2021-07-30T18:40:09.0965249Z   is-express-jwt-options-type-guard.ts |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.0969872Z  ...api-server/src/main/typescript/cmd |   29.17 |     12.5 |       0 |   29.17 |                   
2021-07-30T18:40:09.0972407Z   cactus-api.ts                        |   29.17 |     12.5 |       0 |   29.17 | 13-26,31-36,41    
2021-07-30T18:40:09.0974960Z  ...-server/src/main/typescript/config |   86.92 |    51.35 |   83.33 |   86.72 |                   
2021-07-30T18:40:09.0977641Z   authorization-protocol.ts            |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.0980125Z   config-service.ts                    |   84.71 |       52 |   84.62 |   84.71 | ...84,562-563,593 
2021-07-30T18:40:09.0984381Z   convict-plugin-array-format.ts       |      75 |    16.67 |      50 |      70 | 5,16-17           
2021-07-30T18:40:09.0988847Z   self-signed-pki-generator.ts         |   96.67 |       75 |     100 |   96.67 | 44                
2021-07-30T18:40:09.0993251Z  ...generated/openapi/typescript-axios |   75.19 |    25.68 |   56.67 |   73.21 |                   
2021-07-30T18:40:09.0995613Z   api.ts                               |   89.09 |    68.75 |   68.75 |   91.67 | 204-222           
2021-07-30T18:40:09.0998266Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1000681Z   common.ts                            |   57.14 |     8.33 |      40 |    47.5 | ...94-100,112-116 
2021-07-30T18:40:09.1002357Z   configuration.ts                     |      80 |        0 |      50 |      80 | 98-99             
2021-07-30T18:40:09.1005006Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1008130Z  ...i-server/src/main/typescript/model |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1011943Z   ...ealthcheck-response-type-guard.ts |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1016399Z  ...ain/typescript/prometheus-exporter |      85 |       50 |      80 |      85 |                   
2021-07-30T18:40:09.1019814Z   data-fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1021192Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1024242Z   prometheus-exporter.ts               |   78.57 |       50 |      75 |   78.57 | 34-36             
2021-07-30T18:40:09.1027342Z  ...r/src/main/typescript/web-services |   86.67 |       50 |   83.33 |   86.67 |                   
2021-07-30T18:40:09.1031130Z   watch-healthcheck-v1-endpoint.ts     |   86.67 |       50 |   83.33 |   86.67 | 55-57,67          
2021-07-30T18:40:09.1035011Z  ...tures/plugin-ledger-connector-stub |      82 |       75 |   57.14 |   81.63 |                   
2021-07-30T18:40:09.1036383Z   plugin-ledger-connector-stub.ts      |      82 |       75 |   57.14 |   81.63 | ...31-136,145-147 
2021-07-30T18:40:09.1041015Z  ...ledger-connector-stub/web-services |   84.54 |     8.33 |   87.88 |   84.54 |                   
2021-07-30T18:40:09.1046400Z   deploy-contract-endpoint.ts          |   71.88 |     8.33 |   81.82 |   71.88 | 72,97-105         
2021-07-30T18:40:09.1047676Z   run-transaction-endpoint.ts          |   90.63 |     8.33 |   90.91 |   90.63 | 70,102-103        
2021-07-30T18:40:09.1080118Z   unprotected-action-endpoint.ts       |   90.91 |     8.33 |   90.91 |   90.91 | 75,108-109        
2021-07-30T18:40:09.1082080Z  cactus-common/src/main/typescript     |    82.9 |    64.94 |   89.58 |   82.39 |                   
2021-07-30T18:40:09.1084882Z   bools.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1087924Z   checks.ts                            |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1093073Z   coded-error.ts                       |     100 |       75 |     100 |     100 | 12                
2021-07-30T18:40:09.1093921Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1096623Z   js-object-signer.ts                  |   96.77 |    83.33 |     100 |   96.77 | 34                
2021-07-30T18:40:09.1098548Z   key-converter.ts                     |   46.94 |    26.92 |   71.43 |   45.83 | ...,92-93,118-125 
2021-07-30T18:40:09.1100914Z   objects.ts                           |   93.75 |    88.89 |      75 |     100 | 59                
2021-07-30T18:40:09.1102382Z   public-api.ts                        |     100 |      100 |   90.91 |     100 |                   
2021-07-30T18:40:09.1103288Z   secp256k1-keys.ts                    |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1103946Z   servers.ts                           |   88.64 |    66.67 |   91.67 |   90.24 | 25,30,94,99       
2021-07-30T18:40:09.1104542Z   strings.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1105430Z  ...common/src/main/typescript/logging |   93.94 |    72.73 |   85.71 |   93.94 |                   
2021-07-30T18:40:09.1106972Z   logger-provider.ts                   |     100 |    85.71 |     100 |     100 | 27                
2021-07-30T18:40:09.1107684Z   logger.ts                            |   89.47 |       50 |   81.82 |   89.47 | 46,63             
2021-07-30T18:40:09.1108411Z  ...ommon/src/test/typescript/fixtures |   71.43 |      100 |      50 |   71.43 |                   
2021-07-30T18:40:09.1109419Z   dummy-classes.ts                     |   71.43 |      100 |      50 |   71.43 | 11,24             
2021-07-30T18:40:09.1110486Z  cactus-core-api/src/main/typescript   |     100 |      100 |   83.33 |     100 |                   
2021-07-30T18:40:09.1113612Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1114685Z   public-api.ts                        |     100 |      100 |   83.33 |     100 |                   
2021-07-30T18:40:09.1116287Z  ...generated/openapi/typescript-axios |   93.75 |    81.82 |      90 |   93.62 |                   
2021-07-30T18:40:09.1117062Z   api.ts                               |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1118585Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1119609Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1120819Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1122053Z  ...ore-api/src/main/typescript/plugin |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1123714Z   i-cactus-plugin.ts                   |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1130394Z   plugin-factory.ts                    |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1131263Z  ...rc/main/typescript/plugin/keychain |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1132434Z   is-i-plugin-keychain.ts              |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1133546Z  ...ain/typescript/plugin/object-store |      50 |        0 |       0 |      50 |                   
2021-07-30T18:40:09.1134685Z   is-i-plugin-object-store.ts          |      50 |        0 |       0 |      50 | 4                 
2021-07-30T18:40:09.1135994Z  ...main/typescript/plugin/web-service |     100 |    88.89 |     100 |     100 |                   
2021-07-30T18:40:09.1137133Z   i-endpoint-authz-options.ts          |     100 |    81.82 |     100 |     100 | 35-36             
2021-07-30T18:40:09.1138448Z   i-plugin-web-service.ts              |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1140163Z  cactus-core/src/main/typescript       |    76.4 |     62.5 |   72.41 |   75.29 |                   
2021-07-30T18:40:09.1141380Z   ...ensus-has-transaction-finality.ts |      25 |        0 |       0 |      25 | 10-27             
2021-07-30T18:40:09.1142663Z   consortium-repository.ts             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1143444Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1144713Z   plugin-registry.ts                   |   70.59 |    69.23 |   64.71 |   70.59 | ...18,123,128,132 
2021-07-30T18:40:09.1145695Z   public-api.ts                        |     100 |      100 |      80 |     100 |                   
2021-07-30T18:40:09.1146856Z  ...e/src/main/typescript/web-services |   96.77 |       75 |     100 |   96.77 |                   
2021-07-30T18:40:09.1148073Z   authorization-options-provider.ts    |     100 |       50 |     100 |     100 | 50                
2021-07-30T18:40:09.1149437Z   register-web-service-endpoint.ts     |   93.33 |      100 |     100 |   93.33 | 33                
2021-07-30T18:40:09.1150621Z  ...sortium-manual/src/main/typescript |   95.52 |    85.71 |   83.87 |   95.42 |                   
2021-07-30T18:40:09.1151523Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1152562Z   plugin-consortium-manual.ts          |   94.87 |    85.71 |      88 |   94.78 | 69,91-99,158-159  
2021-07-30T18:40:09.1153921Z   plugin-factory-consortium-manual.ts  |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1155770Z   public-api.ts                        |     100 |      100 |      60 |     100 |                   
2021-07-30T18:40:09.1156714Z  ...ual/src/main/typescript/consortium |    81.9 |    68.75 |   92.59 |    81.9 |                   
2021-07-30T18:40:09.1158038Z   get-consortium-jws-endpoint-v1.ts    |   78.95 |     62.5 |   88.89 |   78.95 | ...,47,76,111-114 
2021-07-30T18:40:09.1159358Z   get-node-jws-endpoint-v1.ts          |    82.5 |    66.67 |      90 |    82.5 | 41,44,80,109-112  
2021-07-30T18:40:09.1163120Z   ...s-exporter-metrics-endpoint-v1.ts |   85.19 |      100 |     100 |   85.19 | 89-92             
2021-07-30T18:40:09.1180651Z  ...generated/openapi/typescript-axios |   79.86 |    37.97 |   62.86 |    79.2 |                   
2021-07-30T18:40:09.1181685Z   api.ts                               |   88.57 |    66.67 |   66.67 |    91.8 | 249-278           
2021-07-30T18:40:09.1182532Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1183738Z   common.ts                            |   63.27 |    20.83 |      50 |      55 | ...9,78-82,94-100 
2021-07-30T18:40:09.1185012Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1186032Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1187263Z  ...ain/typescript/prometheus-exporter |   81.25 |       50 |      75 |   81.25 |                   
2021-07-30T18:40:09.1188083Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1189091Z   prometheus-exporter.ts               |   76.92 |       50 |      75 |   76.92 | 38-40             
2021-07-30T18:40:09.1190231Z  ...eth-besu-erc20/src/main/typescript |    95.4 |       80 |   84.62 |   95.29 |                   
2021-07-30T18:40:09.1190984Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1192115Z   ...in-factory-htlc-eth-besu-erc20.ts |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1193462Z   plugin-htlc-eth-besu-erc20.ts        |   95.95 |       80 |   86.36 |   95.89 | 67-78             
2021-07-30T18:40:09.1194566Z   public-api.ts                        |    87.5 |      100 |   66.67 |   85.71 | 16                
2021-07-30T18:40:09.1195627Z  ...generated/openapi/typescript-axios |   87.28 |    46.61 |   66.67 |   88.67 |                   
2021-07-30T18:40:09.1196637Z   api.ts                               |   90.91 |    56.67 |    67.5 |   94.24 | 763-829           
2021-07-30T18:40:09.1197476Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1198349Z   common.ts                            |   75.51 |    31.25 |      60 |      70 | ...56,65-69,78-82 
2021-07-30T18:40:09.1199262Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1199972Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1200947Z  ...0/src/main/typescript/web-services |   94.85 |       35 |   90.91 |   94.85 |                   
2021-07-30T18:40:09.1202120Z   get-single-status-endpoint.ts        |   91.18 |     8.33 |   90.91 |   91.18 | 56,98-99          
2021-07-30T18:40:09.1203456Z   get-status-endpoint.ts               |   91.43 |       35 |   90.91 |   91.43 | 58,101-102        
2021-07-30T18:40:09.1204524Z   initialize-endpoint.ts               |   96.88 |    41.67 |   90.91 |   96.88 | 61                
2021-07-30T18:40:09.1205626Z   new-contract-endpoint.ts             |   96.77 |    41.67 |   90.91 |   96.77 | 57                
2021-07-30T18:40:09.1206685Z   refund-endpoint.ts                   |   96.77 |    41.67 |   90.91 |   96.77 | 57                
2021-07-30T18:40:09.1207889Z   withdraw-endpoint.ts                 |   96.77 |    41.67 |   90.91 |   96.77 | 57                
2021-07-30T18:40:09.1208986Z  ...-htlc-eth-besu/src/main/typescript |    95.4 |       80 |   80.77 |   95.29 |                   
2021-07-30T18:40:09.1209846Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1211003Z   plugin-factory-htlc-eth-besu.ts      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1212246Z   plugin-htlc-eth-besu.ts              |   95.95 |       80 |   86.36 |   95.89 | 68-75,87          
2021-07-30T18:40:09.1213273Z   public-api.ts                        |    87.5 |      100 |   33.33 |   85.71 | 14                
2021-07-30T18:40:09.1214329Z  ...generated/openapi/typescript-axios |   79.82 |    43.22 |   59.26 |   80.79 |                   
2021-07-30T18:40:09.1215323Z   api.ts                               |   79.87 |       50 |    57.5 |   82.73 | ...05,745-805,853 
2021-07-30T18:40:09.1216183Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1217175Z   common.ts                            |   75.51 |    31.25 |      60 |      70 | ...56,65-69,78-82 
2021-07-30T18:40:09.1218116Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1219089Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1220112Z  ...u/src/main/typescript/web-services |   89.57 |    42.59 |   89.39 |   89.57 |                   
2021-07-30T18:40:09.1221305Z   get-single-status-endpoint.ts        |   94.59 |    42.86 |   90.91 |   94.59 | 56,97             
2021-07-30T18:40:09.1222509Z   get-status-endpoint.ts               |   94.74 |    54.55 |   90.91 |   94.74 | 55,97             
2021-07-30T18:40:09.1223771Z   initialize-endpoint.ts               |   64.71 |     5.56 |   81.82 |   64.71 | 58,83-99          
2021-07-30T18:40:09.1225083Z   new-contract-endpoint.ts             |   94.12 |       50 |   90.91 |   94.12 | 55,86             
2021-07-30T18:40:09.1226176Z   refund-endpoint.ts                   |   94.12 |       50 |   90.91 |   94.12 | 56,88             
2021-07-30T18:40:09.1227236Z   withdraw-endpoint.ts                 |   94.12 |       50 |   90.91 |   94.12 | 55,87             
2021-07-30T18:40:09.1228306Z  ...eychain-aws-sm/src/main/typescript |   61.68 |    51.72 |    37.5 |   61.21 |                   
2021-07-30T18:40:09.1229470Z   plugin-factory-keychain.ts           |   31.58 |        0 |       0 |   31.58 | 26-45             
2021-07-30T18:40:09.1230789Z   ...keychain-aws-sm-remote-adapter.ts |   12.82 |        0 |       0 |   12.82 | 49-152            
2021-07-30T18:40:09.1232082Z   plugin-keychain-aws-sm.ts            |      84 |     62.5 |   68.42 |   83.84 | ...86-287,302-303 
2021-07-30T18:40:09.1233149Z   public-api.ts                        |   88.89 |      100 |      50 |    87.5 | 17                
2021-07-30T18:40:09.1234183Z  ...generated/openapi/typescript-axios |   82.25 |     40.7 |   65.85 |   82.43 |                   
2021-07-30T18:40:09.1235405Z   api.ts                               |   89.47 |    57.14 |   66.67 |   92.86 | 340-380           
2021-07-30T18:40:09.1236230Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1237054Z   common.ts                            |   65.31 |    27.08 |      60 |    57.5 | ...9,78-82,94-100 
2021-07-30T18:40:09.1238136Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1238814Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1239541Z  ...sm/src/main/typescript/webservices |   90.63 |     8.33 |   90.91 |   90.63 |                   
2021-07-30T18:40:09.1240864Z   delete-keychain-entry-endpoint-v1.ts |   90.63 |     8.33 |   90.91 |   90.63 | 61,93-94          
2021-07-30T18:40:09.1242334Z   get-keychain-entry-endpoint-v1.ts    |   90.63 |     8.33 |   90.91 |   90.63 | 61,93-94          
2021-07-30T18:40:09.1243898Z   has-keychain-entry-endpoint-v1.ts    |   90.63 |     8.33 |   90.91 |   90.63 | 61,93-94          
2021-07-30T18:40:09.1245353Z   set-keychain-entry-endpoint-v1.ts    |   90.63 |     8.33 |   90.91 |   90.63 | 61,96-97          
2021-07-30T18:40:09.1246620Z  ...chain-azure-kv/src/main/typescript |   65.38 |    43.48 |   41.67 |   65.79 |                   
2021-07-30T18:40:09.1247769Z   plugin-factory-keychain.ts           |      80 |        0 |       0 |      80 | 25                
2021-07-30T18:40:09.1249317Z   plugin-keychain-azure-kv.ts          |   60.94 |    45.45 |   47.37 |    61.9 | ...28-166,178-194 
2021-07-30T18:40:09.1250416Z   public-api.ts                        |   88.89 |      100 |      25 |    87.5 | 17                
2021-07-30T18:40:09.1251478Z  ...generated/openapi/typescript-axios |   29.46 |        0 |       0 |   23.21 |                   
2021-07-30T18:40:09.1252646Z   api.ts                               |   18.18 |        0 |       0 |   14.58 | ...07-227,248-260 
2021-07-30T18:40:09.1253517Z   base.ts                              |   38.46 |        0 |       0 |   41.67 | 52-55,67-69       
2021-07-30T18:40:09.1254379Z   common.ts                            |   40.82 |        0 |       0 |    27.5 | ...16,126,134-136 
2021-07-30T18:40:09.1255588Z   configuration.ts                     |      10 |        0 |       0 |      10 | 78-99             
2021-07-30T18:40:09.1256269Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1257379Z  ...-azure-kv/src/test/typescript/mock |   71.79 |     87.5 |   33.33 |   71.79 |                   
2021-07-30T18:40:09.1258782Z   plugin-keychain-azure-kv-mock.ts     |   71.79 |     87.5 |   33.33 |   71.79 | 85,107-144        
2021-07-30T18:40:09.1260242Z  ...hain-google-sm/src/main/typescript |   69.23 |    45.45 |   40.91 |   69.84 |                   
2021-07-30T18:40:09.1261417Z   plugin-factory-keychain.ts           |      80 |        0 |       0 |      80 | 24                
2021-07-30T18:40:09.1263692Z   plugin-keychain-google-sm.ts         |   65.38 |       50 |   44.44 |   66.67 | ...01,113-129,140 
2021-07-30T18:40:09.1264841Z   public-api.ts                        |    87.5 |      100 |   33.33 |   85.71 | 16                
2021-07-30T18:40:09.1265903Z  ...generated/openapi/typescript-axios |   29.46 |        0 |       0 |   23.21 |                   
2021-07-30T18:40:09.1267570Z   api.ts                               |   18.18 |        0 |       0 |   14.58 | ...07-227,248-260 
2021-07-30T18:40:09.1268625Z   base.ts                              |   38.46 |        0 |       0 |   41.67 | 52-55,67-69       
2021-07-30T18:40:09.1270092Z   common.ts                            |   40.82 |        0 |       0 |    27.5 | ...16,126,134-136 
2021-07-30T18:40:09.1271049Z   configuration.ts                     |      10 |        0 |       0 |      10 | 78-99             
2021-07-30T18:40:09.1271763Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1272901Z  ...google-sm/src/test/typescript/mock |   92.11 |    71.43 |     100 |   92.11 |                   
2021-07-30T18:40:09.1274290Z   plugin-keychain-google-sm-mock.ts    |   92.11 |    71.43 |     100 |   92.11 | 62,78,90          
2021-07-30T18:40:09.1275600Z  ...eychain-memory/src/main/typescript |   96.67 |    85.71 |   82.35 |   96.61 |                   
2021-07-30T18:40:09.1276356Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1277538Z   plugin-factory-keychain.ts           |     100 |        0 |     100 |     100 | 17                
2021-07-30T18:40:09.1278767Z   plugin-keychain-memory.ts            |   95.65 |      100 |   84.62 |   95.65 | 70,116            
2021-07-30T18:40:09.1279997Z   public-api.ts                        |     100 |      100 |   66.67 |     100 |                   
2021-07-30T18:40:09.1281171Z  ...generated/openapi/typescript-axios |   65.09 |    18.46 |   47.83 |   60.44 |                   
2021-07-30T18:40:09.1282770Z   api.ts                               |    87.5 |    57.14 |   66.67 |   88.89 | 153-162           
2021-07-30T18:40:09.1284183Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1285207Z   common.ts                            |   57.14 |     8.33 |      40 |    47.5 | ...94-100,112-116 
2021-07-30T18:40:09.1286324Z   configuration.ts                     |      10 |        0 |       0 |      10 | 78-99             
2021-07-30T18:40:09.1287004Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1288140Z  ...pt/get-prometheus-exporter-metrics |   85.19 |      100 |     100 |   85.19 |                   
2021-07-30T18:40:09.1289830Z   ...s-exporter-metrics-endpoint-v1.ts |   85.19 |      100 |     100 |   85.19 | 89-92             
2021-07-30T18:40:09.1291661Z  ...ain/typescript/prometheus-exporter |      85 |       50 |      80 |      85 |                   
2021-07-30T18:40:09.1292751Z   data-fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1293697Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1294763Z   prometheus-exporter.ts               |   78.57 |       50 |      75 |   78.57 | 33-35             
2021-07-30T18:40:09.1296024Z  ...keychain-vault/src/main/typescript |   83.44 |    75.51 |   60.98 |   83.75 |                   
2021-07-30T18:40:09.1296779Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1297970Z   plugin-factory-keychain.ts           |   89.47 |    33.33 |     100 |   89.47 | 33,45             
2021-07-30T18:40:09.1299764Z   ...-keychain-vault-remote-adapter.ts |    64.1 |      100 |    37.5 |    64.1 | 92,100-146,154    
2021-07-30T18:40:09.1301266Z   plugin-keychain-vault.ts             |   88.54 |    77.27 |   71.43 |   89.36 | ...39-240,266-267 
2021-07-30T18:40:09.1302347Z   public-api.ts                        |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1303529Z  ...generated/openapi/typescript-axios |   82.61 |    41.94 |   65.96 |   83.23 |                   
2021-07-30T18:40:09.1304568Z   api.ts                               |   89.09 |    57.14 |   66.67 |   92.78 | 401-450           
2021-07-30T18:40:09.1305424Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1306455Z   common.ts                            |   65.31 |    27.08 |      60 |    57.5 | ...9,78-82,94-100 
2021-07-30T18:40:09.1307397Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1308209Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1309286Z  ...ain/typescript/prometheus-exporter |   86.36 |       75 |      80 |   86.36 |                   
2021-07-30T18:40:09.1310526Z   data-fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1311230Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1312368Z   prometheus-exporter.ts               |   81.25 |       75 |      75 |   81.25 | 38-40             
2021-07-30T18:40:09.1313678Z  ...t/src/main/typescript/web-services |   90.42 |       50 |     100 |   90.42 |                   
2021-07-30T18:40:09.1316081Z   delete-keychain-entry-endpoint-v1.ts |   91.43 |       50 |     100 |   91.43 | 99-101            
2021-07-30T18:40:09.1318058Z   get-keychain-entry-endpoint-v1.ts    |   91.43 |       50 |     100 |   91.43 | 100-102           
2021-07-30T18:40:09.1319996Z   ...s-exporter-metrics-endpoint-v1.ts |   85.19 |       50 |     100 |   85.19 | 89-92             
2021-07-30T18:40:09.1321591Z   has-keychain-entry-endpoint-v1.ts    |   91.43 |       50 |     100 |   91.43 | 101-103           
2021-07-30T18:40:09.1323236Z   set-keychain-entry-endpoint-v1.ts    |   91.43 |       50 |     100 |   91.43 | 96-98             
2021-07-30T18:40:09.1324652Z  ...connector-besu/src/main/typescript |   87.65 |     63.2 |   81.58 |   87.58 |                   
2021-07-30T18:40:09.1325408Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1326845Z   model-type-guards.ts                 |      80 |       40 |      50 |      80 | 10                
2021-07-30T18:40:09.1328545Z   plugin-factory-ledger-connector.ts   |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1330000Z   plugin-ledger-connector-besu.ts      |   87.42 |    67.62 |   86.21 |   87.38 | ...52,807,832-837 
2021-07-30T18:40:09.1331606Z   public-api.ts                        |   91.67 |      100 |   66.67 |   90.91 | 21                
2021-07-30T18:40:09.1332709Z  ...esu/src/main/typescript/api-client |     100 |    85.71 |     100 |     100 |                   
2021-07-30T18:40:09.1333769Z   besu-api-client.ts                   |     100 |    85.71 |     100 |     100 | 40                
2021-07-30T18:40:09.1335013Z  ...generated/openapi/typescript-axios |   68.47 |    40.44 |   53.09 |   69.47 |                   
2021-07-30T18:40:09.1336032Z   api.ts                               |   66.97 |    46.15 |   50.75 |    69.7 | ...1733,1816-1828 
2021-07-30T18:40:09.1337020Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1337917Z   common.ts                            |   65.31 |    27.08 |      60 |    57.5 | ...9,78-82,94-100 
2021-07-30T18:40:09.1339179Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1339906Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1340972Z  ...ain/typescript/prometheus-exporter |     100 |       50 |     100 |     100 |                   
2021-07-30T18:40:09.1342221Z   data-fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1342923Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1344082Z   prometheus-exporter.ts               |     100 |       50 |     100 |     100 | 18                
2021-07-30T18:40:09.1345209Z  ...u/src/main/typescript/web-services |   84.36 |    13.89 |   87.72 |   84.36 |                   
2021-07-30T18:40:09.1346622Z   ...act-solidity-bytecode-endpoint.ts |   71.88 |     8.33 |   81.82 |   71.88 | 65,90-98          
2021-07-30T18:40:09.1348012Z   get-balance-endpoint.ts              |   90.63 |     8.33 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1349313Z   get-besu-record-endpoint-v1.ts       |   90.63 |     8.33 |   90.91 |   90.63 | 63,95-96          
2021-07-30T18:40:09.1350709Z   get-block-v1-endpoint-.ts            |   90.63 |     8.33 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1352016Z   get-past-logs-endpoint.ts            |   90.63 |     8.33 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1353364Z   ...s-exporter-metrics-endpoint-v1.ts |   86.21 |       50 |     100 |   86.21 | 88-91             
2021-07-30T18:40:09.1354843Z   get-transaction-endpoint.ts          |   90.63 |     8.33 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1356133Z   invoke-contract-endpoint.ts          |   71.88 |     8.33 |   81.82 |   71.88 | 62,87-95          
2021-07-30T18:40:09.1357523Z   run-transaction-endpoint.ts          |   71.88 |     8.33 |   81.82 |   71.88 | 62,87-95          
2021-07-30T18:40:09.1359804Z   sign-transaction-endpoint-v1.ts      |   86.84 |       75 |      90 |   86.84 | 74,103-106        
2021-07-30T18:40:09.1361874Z   watch-blocks-v1-endpoint.ts          |   85.71 |       50 |      75 |   85.71 | 56-57,71-73       
2021-07-30T18:40:09.1364359Z  ...onnector-corda/src/main/typescript |   81.94 |    83.33 |   40.91 |   81.43 |                   
2021-07-30T18:40:09.1365921Z   plugin-factory-ledger-connector.ts   |      75 |      100 |       0 |      75 | 19                
2021-07-30T18:40:09.1367435Z   plugin-ledger-connector-corda.ts     |   81.03 |    83.33 |   47.06 |    80.7 | ...16,133,172-180 
2021-07-30T18:40:09.1368790Z   public-api.ts                        |      90 |      100 |      25 |   88.89 | 21                
2021-07-30T18:40:09.1369859Z  ...generated/openapi/typescript-axios |   78.74 |    41.35 |   61.82 |   79.12 |                   
2021-07-30T18:40:09.1371013Z   api.ts                               |   89.47 |    60.87 |   68.29 |   93.22 | 972-1028          
2021-07-30T18:40:09.1371872Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1373040Z   common.ts                            |   63.27 |    22.92 |      50 |      55 | ...9,78-82,94-100 
2021-07-30T18:40:09.1374025Z   configuration.ts                     |      10 |        0 |       0 |      10 | 78-99             
2021-07-30T18:40:09.1374852Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1375896Z  ...ain/typescript/prometheus-exporter |   81.25 |       50 |      75 |   81.25 |                   
2021-07-30T18:40:09.1376833Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1377866Z   prometheus-exporter.ts               |   76.92 |       50 |      75 |   76.92 | 35-37             
2021-07-30T18:40:09.1379274Z  ...a/src/main/typescript/web-services |   49.62 |    36.36 |   79.31 |   49.62 |                   
2021-07-30T18:40:09.1380593Z   deploy-contract-jars-endpoint.ts     |   34.18 |    22.22 |   61.54 |   34.18 | 91,118-207        
2021-07-30T18:40:09.1382016Z   ...s-exporter-metrics-endpoint-v1.ts |   85.19 |      100 |     100 |   85.19 | 89-92             
2021-07-30T18:40:09.1383397Z   invoke-contract-endpoint-v1.ts       |   59.26 |      100 |    87.5 |   59.26 | 77-89             
2021-07-30T18:40:09.1384766Z  ...nnector-fabric/src/main/typescript |   79.43 |     59.8 |   58.97 |   79.34 |                   
2021-07-30T18:40:09.1386010Z   chain-code-compiler.ts               |   10.42 |        0 |       0 |   10.42 | 70-170            
2021-07-30T18:40:09.1387324Z   plugin-factory-ledger-connector.ts   |      75 |      100 |       0 |      75 | 18                
2021-07-30T18:40:09.1389021Z   plugin-ledger-connector-fabric.ts    |   87.59 |     66.3 |   68.75 |   87.56 | ...-992,1005-1067 
2021-07-30T18:40:09.1390248Z   public-api.ts                        |      90 |      100 |      25 |   88.89 | 16                
2021-07-30T18:40:09.1391357Z  ...-fabric/src/main/typescript/common |   84.85 |    82.35 |     100 |   84.85 |                   
2021-07-30T18:40:09.1392446Z   create-gateway.ts                    |   84.85 |    82.35 |     100 |   84.85 | 46-55             
2021-07-30T18:40:09.1393780Z  ...rc/main/typescript/deploy-contract |   88.57 |       50 |     100 |   88.57 |                   
2021-07-30T18:40:09.1395844Z   deploy-contract-endpoint-v1.ts       |   88.57 |       50 |     100 |   88.57 | 95-98             
2021-07-30T18:40:09.1397477Z  ...pescript/deploy-contract-go-source |   88.57 |       50 |     100 |   88.57 |                   
2021-07-30T18:40:09.1398846Z   ...contract-go-source-endpoint-v1.ts |   88.57 |       50 |     100 |   88.57 | 95-98             
2021-07-30T18:40:09.1400289Z  ...generated/openapi/typescript-axios |   83.52 |    45.74 |   68.89 |   83.85 |                   
2021-07-30T18:40:09.1401300Z   api.ts                               |   90.74 |    66.67 |   70.97 |   93.81 | 996-1035          
2021-07-30T18:40:09.1402313Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1403331Z   common.ts                            |   65.31 |    27.08 |      60 |    57.5 | ...9,78-82,94-100 
2021-07-30T18:40:09.1404473Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1405171Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1406430Z  ...pt/get-prometheus-exporter-metrics |   85.19 |       50 |     100 |   85.19 |                   
2021-07-30T18:40:09.1407877Z   ...s-exporter-metrics-endpoint-v1.ts |   85.19 |       50 |     100 |   85.19 | 89-92             
2021-07-30T18:40:09.1409272Z  ...or-fabric/src/main/typescript/peer |   71.43 |       60 |     100 |   71.43 |                   
2021-07-30T18:40:09.1410447Z   source-lang-to-runtime-lang.ts       |   71.43 |       60 |     100 |   71.43 | 16-18             
2021-07-30T18:40:09.1412037Z  ...ain/typescript/prometheus-exporter |     100 |       50 |     100 |     100 |                   
2021-07-30T18:40:09.1412860Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1414025Z   prometheus-exporter.ts               |     100 |       50 |     100 |     100 | 17                
2021-07-30T18:40:09.1415279Z  ...rc/main/typescript/run-transaction |   83.87 |       50 |      90 |   83.87 |                   
2021-07-30T18:40:09.1416521Z   run-transaction-endpoint-v1.ts       |   83.87 |       50 |      90 |   83.87 | 74,94-97          
2021-07-30T18:40:09.1419001Z  ...go/hello-world-contract-fabric-v14 |   33.33 |       50 |       0 |   33.33 |                   
2021-07-30T18:40:09.1420872Z   hello-world-contract-go-source.ts    |   33.33 |       50 |       0 |   33.33 | 96-100,104        
2021-07-30T18:40:09.1422294Z  ...nnector-quorum/src/main/typescript |   85.07 |    53.19 |   73.33 |   84.93 |                   
2021-07-30T18:40:09.1423064Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1424191Z   model-type-guards.ts                 |   88.89 |    34.29 |      75 |   88.89 | 30                
2021-07-30T18:40:09.1425584Z   plugin-factory-ledger-connector.ts   |      75 |      100 |       0 |      75 | 18                
2021-07-30T18:40:09.1427198Z   plugin-ledger-connector-quorum.ts    |   84.85 |    71.83 |   77.27 |   84.77 | ...82,495,506,548 
2021-07-30T18:40:09.1428408Z   public-api.ts                        |   88.89 |      100 |   66.67 |    87.5 | 18                
2021-07-30T18:40:09.1429622Z  ...generated/openapi/typescript-axios |   81.87 |       40 |   65.12 |      82 |                   
2021-07-30T18:40:09.1430617Z   api.ts                               |   89.69 |     62.5 |   68.97 |   93.02 | 743-782           
2021-07-30T18:40:09.1431478Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1432520Z   common.ts                            |   63.27 |    20.83 |      50 |      55 | ...9,78-82,94-100 
2021-07-30T18:40:09.1433446Z   configuration.ts                     |     100 |       50 |     100 |     100 | 77-99             
2021-07-30T18:40:09.1434271Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1435439Z  ...ain/typescript/prometheus-exporter |     100 |       50 |     100 |     100 |                   
2021-07-30T18:40:09.1436302Z   data.fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1436996Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1438173Z   prometheus-exporter.ts               |     100 |       50 |     100 |     100 | 18                
2021-07-30T18:40:09.1439572Z  ...m/src/main/typescript/web-services |    89.6 |    21.05 |   92.68 |    89.6 |                   
2021-07-30T18:40:09.1441236Z   ...act-solidity-bytecode-endpoint.ts |   90.63 |    16.67 |   90.91 |   90.63 | 65,97-98          
2021-07-30T18:40:09.1442986Z   ...s-exporter-metrics-endpoint-v1.ts |   86.21 |      100 |     100 |   86.21 | 88-91             
2021-07-30T18:40:09.1444420Z   invoke-contract-endpoint.ts          |   90.63 |    16.67 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1446338Z   run-transaction-endpoint.ts          |   90.63 |    16.67 |   90.91 |   90.63 | 62,94-95          
2021-07-30T18:40:09.1447689Z  ...connector-xdai/src/main/typescript |   72.57 |    54.55 |   51.72 |   72.34 |                   
2021-07-30T18:40:09.1448762Z   model-type-guards.ts                 |      80 |     37.5 |      50 |      80 | 10                
2021-07-30T18:40:09.1450170Z   plugin-factory-ledger-connector.ts   |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1451763Z   plugin-ledger-connector-xdai.ts      |   71.23 |    56.25 |   54.55 |    71.1 | ...18,527,539,605 
2021-07-30T18:40:09.1453203Z   public-api.ts                        |   88.89 |      100 |      25 |    87.5 | 16                
2021-07-30T18:40:09.1454310Z  ...generated/openapi/typescript-axios |   45.98 |    19.57 |   31.82 |   43.14 |                   
2021-07-30T18:40:09.1455760Z   api.ts                               |      39 |    29.41 |      30 |   39.33 | ...98,819,842-854 
2021-07-30T18:40:09.1456812Z   base.ts                              |   76.92 |    66.67 |      50 |      75 | 67-69             
2021-07-30T18:40:09.1458394Z   common.ts                            |   57.14 |     8.33 |      40 |    47.5 | ...94-100,112-116 
2021-07-30T18:40:09.1459612Z   configuration.ts                     |      10 |        0 |       0 |      10 | 78-99             
2021-07-30T18:40:09.1460466Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1461626Z  ...ain/typescript/prometheus-exporter |     100 |       50 |     100 |     100 |                   
2021-07-30T18:40:09.1462887Z   data-fetcher.ts                      |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1464407Z   metrics.ts                           |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1465703Z   prometheus-exporter.ts               |     100 |       50 |     100 |     100 | 18                
2021-07-30T18:40:09.1466867Z  ...i/src/main/typescript/web-services |    75.2 |    10.53 |   85.37 |    75.2 |                   
2021-07-30T18:40:09.1468922Z   ...act-solidity-bytecode-endpoint.ts |   71.88 |     8.33 |   81.82 |   71.88 | 65,90-98          
2021-07-30T18:40:09.1470504Z   ...s-exporter-metrics-endpoint-v1.ts |   86.21 |       50 |     100 |   86.21 | 88-91             
2021-07-30T18:40:09.1471846Z   invoke-contract-endpoint.ts          |   71.88 |     8.33 |   81.82 |   71.88 | 62,87-95          
2021-07-30T18:40:09.1473075Z   run-transaction-endpoint.ts          |   71.88 |     8.33 |   81.82 |   71.88 | 62,87-95          
2021-07-30T18:40:09.1474429Z  ...s-test-tooling/src/main/typescript |     100 |      100 |   40.74 |     100 |                   
2021-07-30T18:40:09.1475558Z   i-key-pair.ts                        |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1476430Z   index.ts                             |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1477382Z   public-api.ts                        |     100 |      100 |   39.62 |     100 |                   
2021-07-30T18:40:09.1478364Z  ...t-tooling/src/main/typescript/besu |    62.2 |    47.67 |    62.5 |   61.73 |                   
2021-07-30T18:40:09.1479651Z   besu-mp-test-ledger.ts               |   10.26 |        0 |       0 |   10.26 | 39-197            
2021-07-30T18:40:09.1480996Z   besu-test-ledger.ts                  |   86.31 |    65.08 |   97.22 |   86.06 | ...80,387,396,402 
2021-07-30T18:40:09.1482664Z  ...cript/cactus-keychain-vault-server |   85.11 |    68.75 |     100 |   85.11 |                   
2021-07-30T18:40:09.1484317Z   cactus-keychain-vault-server.ts      |   85.11 |    68.75 |     100 |   85.11 | ...06,121-122,135 
2021-07-30T18:40:09.1485314Z  ...tooling/src/main/typescript/common |   79.78 |    52.31 |   87.27 |   79.39 |                   
2021-07-30T18:40:09.1486060Z   containers.ts                        |   81.67 |    58.93 |   88.89 |   81.28 | ...68,573,607,613 
2021-07-30T18:40:09.1487151Z   streams.ts                           |   62.96 |    11.11 |      80 |   62.96 | 28-37,63-68       
2021-07-30T18:40:09.1488130Z  ...-tooling/src/main/typescript/corda |   93.17 |    76.32 |   93.55 |   93.08 |                   
2021-07-30T18:40:09.1489561Z   corda-test-ledger.ts                 |   93.13 |    76.32 |   93.55 |   93.04 | ...98,362-366,387 
2021-07-30T18:40:09.1490952Z   sample-cordapp-enum.ts               |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1492604Z  ...rc/main/typescript/corda-connector |   89.66 |    55.17 |     100 |   89.53 |                   
2021-07-30T18:40:09.1493929Z   corda-connector-container.ts         |   89.66 |    55.17 |     100 |   89.53 | ...73,190,217,239 
2021-07-30T18:40:09.1495022Z  ...tooling/src/main/typescript/fabric |   89.25 |    55.36 |      96 |   89.13 |                   
2021-07-30T18:40:09.1496460Z   fabric-test-ledger-v1.ts             |   89.25 |    55.36 |      96 |   89.13 | ...74,490,508-514 
2021-07-30T18:40:09.1497627Z  ...src/main/typescript/github-actions |   92.31 |    66.67 |     100 |   92.31 |                   
2021-07-30T18:40:09.1499014Z   is-running-in-github-action.ts       |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1500795Z   prune-docker-all-if-github-action.ts |   88.89 |       50 |     100 |   88.89 | 19                
2021-07-30T18:40:09.1502711Z  ...ooling/src/main/typescript/go-ipfs |   11.27 |        0 |       0 |   11.27 |                   
2021-07-30T18:40:09.1503925Z   go-ipfs-test-container.ts            |   11.27 |        0 |       0 |   11.27 | 40-190            
2021-07-30T18:40:09.1505697Z  ...ling/src/main/typescript/http-echo |      70 |    51.16 |   86.96 |   69.07 |                   
2021-07-30T18:40:09.1507413Z   http-echo-container.ts               |      70 |    51.16 |   86.96 |   69.07 | ...06,215,221,243 
2021-07-30T18:40:09.1508425Z  ...oling/src/main/typescript/keycloak |    7.64 |        0 |       0 |    7.86 |                   
2021-07-30T18:40:09.1509534Z   keycloak-container.ts                |    7.64 |        0 |       0 |    7.86 | 48-352            
2021-07-30T18:40:09.1510495Z  ...ing/src/main/typescript/localstack |      74 |    57.14 |   83.33 |      74 |                   
2021-07-30T18:40:09.1511630Z   localstack-container.ts              |      74 |    57.14 |   83.33 |      74 | ...11,123,138-149 
2021-07-30T18:40:09.1513604Z  ...g/src/main/typescript/openethereum |   76.74 |    63.16 |   92.86 |   76.74 |                   
2021-07-30T18:40:09.1515121Z   openethereum-test-ledger.ts          |   76.74 |    63.16 |   92.86 |   76.74 | ...06,231-232,242 
2021-07-30T18:40:09.1516181Z  ...tooling/src/main/typescript/quorum |   81.13 |    61.02 |   88.89 |   80.77 |                   
2021-07-30T18:40:09.1517380Z   quorum-test-ledger.ts                |   81.13 |    61.02 |   88.89 |   80.77 | ...63,369,380,386 
2021-07-30T18:40:09.1518657Z  ...rc/main/typescript/rustc-container |   79.76 |    58.06 |   78.57 |   79.76 |                   
2021-07-30T18:40:09.1520005Z   rustc-build-cmd.ts                   |     100 |      100 |     100 |     100 |                   
2021-07-30T18:40:09.1521187Z   rustc-container.ts                   |   79.52 |    58.06 |   78.57 |   79.52 | ...98-199,210-217 
2021-07-30T18:40:09.1522410Z  .../main/typescript/vault-test-server |   82.69 |       75 |   91.67 |   82.69 |                   
2021-07-30T18:40:09.1523537Z   vault-test-server.ts                 |   82.69 |       75 |   91.67 |   82.69 | ...28,143-144,154 
2021-07-30T18:40:09.1524836Z ---------------------------------------|---------|----------|---------|---------|-------------------

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 8 times, most recently from 45d721e to 9b5af88 Compare August 6, 2021 14:06
@Leeyoungone
Copy link
Contributor Author

I'm not sure what it is but I've triggered the CI about thrice (maybe four times) now but It seems to constantly fail the last run. Maybe there's an actual error I need to look at @petermetz ?

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch from 9b5af88 to 883945c Compare August 9, 2021 14:09
@petermetz
Copy link
Contributor

I'm not sure what it is but I've triggered the CI about thrice (maybe four times) now but It seems to constantly fail the last run. Maybe there's an actual error I need to look at @petermetz ?

@Leeyoungone I agree we are now justified to be suspicious of this not being just a flake but an actual issue that needs fixing.
Could you please try to reproduce the test failure locally by running the same test case that's been failing according to the CI logs? I'm guessing that it will pass locally, but maybe not and then we can take it from there depending on the outcome of that experiment.

petermetz
petermetz requested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leeyoungone

The package-lock file can be deleted, we don't need it since the migration to yarn.

packages/cactus-core-api/src/main/json/openapi.json has changes in the diff, these should go to the parent PR if there are still changes to be made to make it work for all the
feat(keychain-*): complete request handler and endpoints PRs

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 4 times, most recently from 2df2526 to 4fbbcc9 Compare September 21, 2021 16:54
@Leeyoungone
Copy link
Contributor Author

@petermetz I've deleted the package-lock file! I'm still working on the parent PR but I've made it so that the keychains are dependent on the new PR. Thanks again!

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 4 times, most recently from 5775408 to 56de06b Compare September 22, 2021 16:22
@petermetz
Copy link
Contributor

@petermetz I've deleted the package-lock file! I'm still working on the parent PR but I've made it so that the keychains are dependent on the new PR. Thanks again!

@Leeyoungone Thank you, ping me for the final review once the parent PR has been merged (which should put this one in a state where the diff here no longer changes the core-api openapi.json spec)

@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

petermetz
petermetz requested changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leeyoungone Please rebase onto latest upstream/main + resolve conflicts (then the extra baggage should disappear from the diff)

@Leeyoungone Leeyoungone force-pushed the feat-967-complete-request-handler-and-endpoints branch 4 times, most recently from f031d2e to 51baf5e Compare October 4, 2021 20:43
@Leeyoungone Leeyoungone requested a review from petermetz October 4, 2021 20:43
@Leeyoungone
Copy link
Contributor Author

I think this PR is ready to go!

@Leeyoungone @petermetz
feat(keychain-aws-sm): complete request handler and endpoint
2ada34f 
Fixes hyperledger-cacti#967
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@petermetz petermetz force-pushed the feat-967-complete-request-handler-and-endpoints branch from 51baf5e to 2ada34f Compare October 6, 2021 18:09
petermetz
petermetz approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leeyoungone LGTM

@petermetz petermetz merged commit e6099b8 into hyperledger-cacti:main Oct 8, 2021
@Leeyoungone Leeyoungone deleted the feat-967-complete-request-handler-and-endpoints branch October 11, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@petermetz petermetz petermetz approved these changes

@jonathan-m-hamilton jonathan-m-hamilton Awaiting requested review from jonathan-m-hamilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leeyoungone @codecov-commenter @petermetz @takeutak