-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(whitepaper): add a section of APIs and communication protocols #179
docs(whitepaper): add a section of APIs and communication protocols #179
Conversation
Note that this pull-request is linked with the issue-list #178 |
Thanks for your comment, Peter! I fixed not only the contents table number but the section numbers. |
@takeutak These are the comments I meant during the call, they are visible if you navigate to the old #160 PR and scroll down a bit. For reference, see screenshot below: |
I fixed the whitepaper changing /v1/... to /bl-api/vi/... reflecting your advice, Peter. If you had written other comments on my old pull-request #160 , would you mind if you paste them in the new pull-request? |
Any chance that it could be Reasoning: I'm advocating for using the greater to smaller hierarchical organization of the path elements so that what's on the left is a super-set of what's on the right when comparing any adjacent path elements. In other words: All APIs are APIs, some of them might be const isApiReq = req.path.startsWith("/api/") || req.path.startsWith("/bl-api/"); Which would of course work, but it is increasing the number of if conditions (implicit or explicit, doesn't matter) in the code linearly scaling up with the number of different APIs that we will invent in the future (which I expect to be unbounded given our design principles strongly favoring extensibility/flexibility/pluggability/etc.) In general, I'm always out on a quest to eliminate if conditions in code when possible because they are slippery slopes leading to arrow programming in it's worst, but even when used moderately they are increasing the number of valid execution paths the code can take exponentially since if conditions open up separate branches of the decision tree as the code execution if progressing. (of course there are justified uses of if conditions since without them most software would be pretty useless, but you get the point) I know this is getting super abstract and kinda off-topic, but I wanted to make sure I explain my thoughts on this in detail because whenever I talk about things like this I'm always self-conscious about it looking like dumb hair splitting/preaching dogmas (like who cares about two extra characters in the request path, right?).
Yeah I had like 5 or 6 of them. In the meantime, here are all the comments of mine from the previous PR (Github support might take a while, their auto response said they de-prioritize tickets because of the virus and their reduced staff). |
As Peter's comment on Cactus meeting, I fixed my pull-request (from /bl-api/v1/ to /api/v1/bl/ ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oops, there's a conflict in the table of contents because of the other whitepaper PR I just merged in a minute ago. |
Signed-off-by: Takuma TAKEUCHI <takeuchi.takuma@fujitsu.com>
…ommunication protocols Signed-off-by: Takuma TAKEUCHI <takeuchi.takuma@fujitsu.com>
…ion protocols Signed-off-by: Takuma TAKEUCHI <takeuchi.takuma@fujitsu.com>
…tocols Signed-off-by: Takuma TAKEUCHI <takeuchi.takuma@fujitsu.com>
This pull-request is mainly modified from PR#160 , but slightly changed from that PR (newly adding an API table of Verifier and Validator)
Signed-off-by: Takuma TAKEUCHI takeuchi.takuma@fujitsu.com