feat(common): Servers utility class #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #275 |
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 5, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
|
Could we discuss this component again at next week's Contributors' meeting? |
@takeutak Sure, happy to discuss. Please also note: We could also discuss here in the comments. It would be great if we could reduce the average turnaround time for the PRs by not having to wait for the weekly calls with Q/As (I understand sometimes it's a lengthier discussion that is not well suited for comments, but in other cases it ends up being just a few short sentences anyway) |
Useful when working with HTTP servers especially for test case authoring where there's a lot of server creation for the purpose of allocating random ports prior to launching an API server instance. Fixes hyperledger-cacti#260 Fixes hyperledger-cacti#267 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feat/common/servers-utility-class-260--267
branch
from
d3563b7 to
d7fadb2
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 18, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 1, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 2, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 6, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 7, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when working with HTTP servers especially for
test case authoring where there's a lot of server
creation for the purpose of allocating random ports
prior to launching an API server instance.
Fixes #260
Fixes #267
Depends on #275
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com