refactor(sdk):renamed sdk package to api client

[yash2189]

Fixes #314

Previously there was a package named cactus-sdk which had ambiguity within the project since it was referred to as an SDK of SDK's. This PR renames the cactus-sdk to cactus-api-client and changes the documentation , files supporting the same.

What has been updated ?
1 . In the package.json file, the properties: name, main, browser, browserMinified, mainMinified properties are all updated
2. The references in all the other packages are also updated to import the new package instead of the old one
3. Documentation is updated (README.md)

The changes for the updated directory can be found here

[petermetz]

@yash2189 Thank you for the PR! Two things:

1. The build has to work, but you've got compilation errors in some of the code still.
2. The commit message is invalid, I think you are missing a space character after the colon.

Other than these (and with the assumption that the CI will pass) it looks good to me.

[yash2189]

@petermetz Thanks for the review. The errors a related to npm linting and lerna . Could you please tell me about the errors as I'm quite confused.

[petermetz]

@petermetz Thanks for the review. The errors a related to npm linting and lerna . Could you please tell me about the errors as I'm quite confused.

@yash2189 I think you forgot to replace all the package imports from 'sdk' to 'api-client' in the code of the other packages that depend on @hyperledger/cactus-sdk.

See: https://travis-ci.org/github/hyperledger/cactus/jobs/738502564#L592

[petermetz]

@yash2189 Looks like now you added one too many spaces. The one on the left from the parentheses is tripping the commit message linter if I'm guessing it right.
refactor (ask): renamed sdk package to api client should be refactor(sdk): renamed sdk package to api client
(also I assume the ask part is meant to be sdk

[yash2189]

@yash2189 Looks like now you added one too many spaces. The one on the left from the parentheses is tripping the commit message linter if I'm guessing it right.
refactor (ask): renamed sdk package to api client should be refactor(sdk): renamed sdk package to api client
(also I assume the ask part is meant to be sdk

sorry typo , I'm doing it again

[yash2189]

Hi @petermetz , All the 3 checks have been passed , I have made the changes.
Please tell me whether I need to squash the commits ?
Thanks.

[petermetz]

Hi @petermetz , All the 3 checks have been passed , I have made the changes.
Please tell me whether I need to squash the commits ?
Thanks.

Awesome, thank you so much @yash2189 !
Yes, please do squash the commits into a single one and then it LGTM!

[yash2189]

@petermetz Done! Thanks for guiding me throughout the process. :)

[petermetz]

LGTM

[takeutak]

LGTM