Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(plugin-keychain-memory): fix local imports broken due to .js exts #3255

Merged
merged 1 commit into from
May 16, 2024

Conversation

petermetz
Copy link
Contributor

Found the solution and a long discussion about it here:
kulshekhar/ts-jest#1057

TLDR: The Jest resolver needs a little extra information/tweak to the
config so that it can correctly handle the .js imports.

Specifically this comment provided the solution which I made here:
kulshekhar/ts-jest#1057 (comment)

Fixes #3254

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the petermetz/issue3254 branch from efc8242 to 1406e8f Compare May 16, 2024 02:56
@sandeepnRES
Copy link
Contributor

Hi @petermetz yarn-codegen test is failing. As it is a required test, hence I approved the PR, as it is already blocking the PR.

@petermetz
Copy link
Contributor Author

Hi @petermetz yarn-codegen test is failing. As it is a required test, hence I approved the PR, as it is already blocking the PR.

@sandeepnRES Thank you for the review! I'm retrying the codegen task now (it's the old flake that has returned so it usually just needs another go, fingers crossed)

Found the solution and a long discussion about it here:
kulshekhar/ts-jest#1057

TLDR: The Jest resolver needs a little extra information/tweak to the
config so that it can correctly handle the .js imports.

Specifically this comment provided the solution which I made here:
kulshekhar/ts-jest#1057 (comment)

Fixes hyperledger-cacti#3254

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the petermetz/issue3254 branch from 1406e8f to 67eb8e5 Compare May 16, 2024 13:25
@petermetz petermetz merged commit 3e4f4a7 into hyperledger-cacti:main May 16, 2024
130 of 144 checks passed
@petermetz petermetz deleted the petermetz/issue3254 branch May 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(plugin-keychain-memory): fix local imports broken due to .js extensions
4 participants