Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroha-connector): add prometheus exporter to the plugin #3461

Closed
wants to merge 1 commit into from
Closed

feat(iroha-connector): add prometheus exporter to the plugin #3461

wants to merge 1 commit into from

Conversation

ashnashahgrover
Copy link
Contributor

Commit to be reviewed

feat(iroha-connector): add prometheus exporter to the plugin
 

Primary Changes
----------------
1. Added Prometheus Exporter to Iroha ledger plugin
2. Added Prometheus Metrics tracker to relevant iroha tests.

Fixes #1260

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@ashnashahgrover ashnashahgrover changed the title  feat(iroha-connector): add prometheus exporter to the plugin #1260  feat(iroha-connector): add prometheus exporter to the plugin Aug 5, 2024
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch from 8a9e656 to 901cab4 Compare August 5, 2024 23:03
@ashnashahgrover ashnashahgrover changed the title  feat(iroha-connector): add prometheus exporter to the plugin feat(iroha-connector): add prometheus exporter to the plugin Aug 5, 2024
jagpreetsinghsasan
jagpreetsinghsasan requested changes Aug 6, 2024
View reviewed changes
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts Outdated Show resolved Hide resolved
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts Outdated Show resolved Hide resolved
...cactus-plugin-ledger-connector-iroha2/src/main/typescript/cactus-iroha-sdk-wrapper/client.ts Outdated Show resolved Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts Outdated Show resolved Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts Outdated Show resolved Hide resolved
...r-connector-iroha2/src/test/typescript/integration/iroha2-setup-and-basic-operations.test.ts Outdated Show resolved Hide resolved
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch 3 times, most recently from d12876e to 44b7c44 Compare August 6, 2024 15:38
@ashnashahgrover
Copy link
Contributor Author

@jagpreetsinghsasan Have addressed all requested changes.

petermetz
petermetz requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnashahgrover LGTM with comments (mostly just nit-picks)

...ector-iroha2/src/main/typescript/web-services/get-prometheus-exporter-metrics-endpoint-v1.ts Outdated Show resolved Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts Outdated Show resolved Hide resolved
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch from 44b7c44 to ea7557d Compare August 11, 2024 22:21
@ashnashahgrover
Copy link
Contributor Author

@ashnashahgrover LGTM with comments (mostly just nit-picks)

Have addressed all the requests.

petermetz
petermetz approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnashahgrover Thank you for the updates, LGTM!

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch from ea7557d to 4740710 Compare August 14, 2024 20:36
outSH
outSH approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM, please fix the CI so we can proceed with merging

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch from 4740710 to c60fe15 Compare August 16, 2024 18:12
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch 2 times, most recently from fe6f61f to 0aa2d50 Compare September 3, 2024 00:29
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue1260 branch from 0aa2d50 to d2b3c64 Compare September 21, 2024 00:46
@petermetz
Copy link
Contributor

Currently this one is stuck because of a pending change request from @jagpreetsinghsasan

@ashnashahgrover In case you didn't re-request review from @jagpreetsinghsasan , please do that.
@jagpreetsinghsasan If there was a re-request review then please re-review when you get the chance so that we can move this along.

I'm not sure either way where did this one get stuck, but either which way let's get in moving!

@jagpreetsinghsasan
Copy link
Contributor

Yes, I think it got stuck because of my non-approval due to multiple workflow failures. LGTM

@jagpreetsinghsasan jagpreetsinghsasan dismissed their stale review October 3, 2024 03:31

Changes incorporated and approved by Peter

@ashnashahgrover @petermetz
feat(iroha-connector): add prometheus exporter to the plugin
d3f3163 
 
Primary Changes
----------------
1. Added Prometheus Exporter to Iroha ledger plugin
2. Added Prometheus Metrics tracker to relevant iroha tests.
 
Fixes hyperledger-cacti#1260

Signed-off-by: ashnashahgrover <as19@williams.edu>
@petermetz petermetz force-pushed the ashnashahgrover/issue1260 branch from d2b3c64 to d3f3163 Compare October 3, 2024 22:19
petermetz
petermetz requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan Got it, thank you!

@ashnashahgrover Please fix the DCO check and then we are good to merge (please hit the re-request review button once you've updated the commit signoff)

https://github.com/hyperledger/cacti/actions/runs/11170598967/job/31053751225?pr=3461

@petermetz
Copy link
Contributor

Closing for now due to inactivity. We can reopen at is anytime in the future as needed.

@petermetz petermetz closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz requested changes

@outSH outSH outSH approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan left review comments

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(iroha-connector): add prometheus exporter to the plugin
4 participants
@ashnashahgrover @petermetz @jagpreetsinghsasan @outSH