Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2 #3478

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

petermetz
Copy link
Contributor

  1. Fixes the GitHub action linter warnings (the ones that show up on the
    summary page of the action execution)
  2. Adds another ignore line to the eslint ignore file that randomly popped up:
    weaver/core/identity-management/iin-agent/out/

Fixes #3477

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Fixes the GitHub action linter warnings (the ones that show up on the
summary page of the action execution)
2. Adds another ignore line to the eslint ignore file that randomly popped up:
`weaver/core/identity-management/iin-agent/out/`

Fixes hyperledger-cacti#3477

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the petermetz/issue3477 branch from 164ec1e to 0eaea18 Compare August 13, 2024 18:12
@petermetz petermetz merged commit 9ce9057 into hyperledger-cacti:main Aug 13, 2024
142 of 144 checks passed
@petermetz petermetz deleted the petermetz/issue3477 branch August 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): upgrade setup-node@v4.0.3 checkout@v4.1.7 cache@v4.0.2
4 participants