Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weaver): upgrade to corda 4.12 and jvm 17 #3479

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

sandeepnRES
Copy link
Contributor

@sandeepnRES sandeepnRES commented Aug 13, 2024

feat(weaver): upgrade to corda 4.12 and jvm 17

  • upgrade gradle to 7.6.1
  • upgrade to kotlin 1.9
  • upgrade corda dependencies to 4.12 and java to 17
  • update java to 17 for corda workflows
  • generate corda 4.12 testnet artifacts
  • use bootstrap-states.csv to init corda SimpleStates
  • added FREE_UP_GITHUB_RUNNER_DISK_SPACE_DISABLED to free space on data-sharing-docker-local job

chore: updating golang version in docs, and proto-grpc dependencies

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@VRamakrishna VRamakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES This is really great, thanks for the long overdue upgrade and testing. I just had several cleanup-related questions and comments.

@VRamakrishna
Copy link
Contributor

@petermetz I think the Corda connector and any examples in the non-Weaver parts of Cacti ought to be similarly upgraded (assuming they have not already been done). This change will allow us to finally escape Java 8 and also avoid periodic vulnerability reports.

@petermetz
Copy link
Contributor

@petermetz I think the Corda connector and any examples in the non-Weaver parts of Cacti ought to be similarly upgraded (assuming they have not already been done). This change will allow us to finally escape Java 8 and also avoid periodic vulnerability reports.

@VRamakrishna I couldn't agree more and I was going to propose the exact same thing for the same reasons myself, I'm glad we are thinking alike about this! :-)
I'll send in a pull request soon as well with the cactus corda connector being bumped up to JDK 17, Spring Boot 3 and Gradle 8 and Corda 4.12 as well. I'm very happy about this!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES Thank you very much, this is great! Please fix the merge conflicts and pass it back for review, but from what I can see right now, we are good to go!

@sandeepnRES
Copy link
Contributor Author

sandeepnRES commented Aug 14, 2024

Hi @petermetz Resolved the conflict. Please review.

@sandeepnRES sandeepnRES force-pushed the corda_4.12_jvm17 branch 2 times, most recently from 6d2d8db to ab269e3 Compare August 14, 2024 07:45
@sandeepnRES
Copy link
Contributor Author

sandeepnRES commented Aug 14, 2024

Hi @petermetz there's some docs updates I've also added, those are small changes that Rama and me didn't want to open new PR for, but still is orthogonal to this PR, so that's why I've kept the commit separate.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES Sounds good to me. The data-sharing-docker-local CI job has been running for 4 hours - I'm guessing it's stuck. I'll do a rebase onto main and that will trigger the re-run, hopefully it was just a fluke.

@sandeepnRES sandeepnRES force-pushed the corda_4.12_jvm17 branch 2 times, most recently from 1834d83 to 9db883b Compare August 14, 2024 18:16
* upgrade gradle to 7.6.1
* upgrade to kotlin 1.9
* upgrade corda dependencies to 4.12 and java to 17
* update java to 17 for corda workflows
* generate corda 4.12 testnet artifacts
* use bootstrap-states.csv to init corda SimpleStates
* added FREE_UP_GITHUB_RUNNER_DISK_SPACE_DISABLED to
    free space on data-sharing-docker-local job using tools/ci.sh script

Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
@sandeepnRES sandeepnRES enabled auto-merge (rebase) August 14, 2024 19:16
@sandeepnRES sandeepnRES merged commit 30cde8b into hyperledger-cacti:main Aug 14, 2024
142 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants