-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weaver): upgrade to corda 4.12 and jvm 17 #3479
feat(weaver): upgrade to corda 4.12 and jvm 17 #3479
Conversation
...rkflows/src/main/kotlin/org/hyperledger/cacti/weaver/imodule/corda/flows/ViewVerification.kt
Outdated
Show resolved
Hide resolved
...ows/src/test/kotlin/org/hyperledger/cacti/weaver/imodule/corda/HandleExternalRequestTests.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeepnRES This is really great, thanks for the long overdue upgrade and testing. I just had several cleanup-related questions and comments.
@petermetz I think the Corda connector and any examples in the non-Weaver parts of Cacti ought to be similarly upgraded (assuming they have not already been done). This change will allow us to finally escape Java 8 and also avoid periodic vulnerability reports. |
da17496
to
8cdf499
Compare
@VRamakrishna I couldn't agree more and I was going to propose the exact same thing for the same reasons myself, I'm glad we are thinking alike about this! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeepnRES Thank you very much, this is great! Please fix the merge conflicts and pass it back for review, but from what I can see right now, we are good to go!
8cdf499
to
5b2c20d
Compare
Hi @petermetz Resolved the conflict. Please review. |
5b2c20d
to
8788ec8
Compare
6d2d8db
to
ab269e3
Compare
Hi @petermetz there's some docs updates I've also added, those are small changes that Rama and me didn't want to open new PR for, but still is orthogonal to this PR, so that's why I've kept the commit separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeepnRES Sounds good to me. The data-sharing-docker-local CI job has been running for 4 hours - I'm guessing it's stuck. I'll do a rebase onto main and that will trigger the re-run, hopefully it was just a fluke.
8ce12c3
to
13fafdd
Compare
1834d83
to
9db883b
Compare
* upgrade gradle to 7.6.1 * upgrade to kotlin 1.9 * upgrade corda dependencies to 4.12 and java to 17 * update java to 17 for corda workflows * generate corda 4.12 testnet artifacts * use bootstrap-states.csv to init corda SimpleStates * added FREE_UP_GITHUB_RUNNER_DISK_SPACE_DISABLED to free space on data-sharing-docker-local job using tools/ci.sh script Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
9db883b
to
bcefeed
Compare
feat(weaver): upgrade to corda 4.12 and jvm 17
chore: updating golang version in docs, and proto-grpc dependencies
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.