Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix type exports in packages/cacti-plugin-copm-fabric #3702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Dec 12, 2024

Commit to be reviewed


ci(github): fix type exports in packages/cacti-plugin-copm-fabric

Primary Changes
---------------
1. Removed packages/cacti-plugin-copm-fabric/hyperledger-cacti-cacti-plugin-
copm-fabric-*.tgz in ignore paths in get-all-tgz-path.ts file
2. Added main, module, types, and files in package.json

Fixes: #3629

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@ruzell22
Copy link
Contributor Author

With the code changes, attw gives all green passing result
image
image

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 LGTM with comments: Please fix the merge conflict - otherwise it's looking good to me.

Primary Changes
---------------
1. Removed packages/cacti-plugin-copm-fabric/hyperledger-cacti-cacti-plugin-
copm-fabric-*.tgz in ignore paths in get-all-tgz-path.ts file
2. Added main, module, types, and files in package.json

Fixes: hyperledger-cacti#3629

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@ruzell22
Copy link
Contributor Author

Apologies for the delay on pushing, I had issue with my device and the yarn run configure with fork in the past few days but I have updated my fork now to resolve merge conflict, thanks @petermetz

@ruzell22 ruzell22 requested a review from petermetz December 18, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): fix type exports in packages/cacti-plugin-copm-fabric
3 participants