Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix type exports in packages/cacti-ledger-browser #3706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Dec 18, 2024

Commit to be reviewed


ci(github): fix type exports in packages/cacti-plugin-copm-fabric

Primary Changes
---------------
1. Removed packages/cacti-ledger-browser/hyperledger-cacti-ledger-browser-*.tgz
in ignore paths in get-all-tgz-path.ts file
2. Added main, module, types, and files in package.json

Fixes: #3630

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
---------------
1. Removed packages/cacti-ledger-browser/hyperledger-cacti-ledger-browser-*.tgz
in ignore paths in get-all-tgz-path.ts file
2. Added main, module, types, and files in package.json

Fixes: hyperledger-cacti#3630

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@ruzell22
Copy link
Contributor Author

This code change has the same output as #3675 wherein the custom-checks is passing but the container does not contain any types.
image
image
Reference: #3675 (comment)

Will make similar steps discussed by @petermetz here (#3675 (review)) for this ticket as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): fix type exports in packages/cacti-ledger-browser
2 participants