fix(cockpit): compilation issues #496 #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full build with frontend components included are now working once again. 1. The cockpit components no longer depend on the api-client package shipping the standard typescript-axios client types such as DefaultApi, Configuration and the likes. This is because we hollowed out the client-api package to only contain the extensions to these generated types mentioned above (provided via typescript-axios OpenAPI generator) This is part of a larger ongoing effort where we decoupled the api-client and the cmd-api-server packages where earlier there was some tangling between the two in the form of the cmd-api-server exporting it's openapi spec onto the api-client package which in hindsight didn't make much sense to be honest. Mistakes were made, but now are being fixed. 2. A related, but not strictly necessary, cleanup type of change is that we also deleted the remnants of the generated code from the api-client package, e.g. the whole ./generated/openapi/typescrit-axios/ folder is now gone properly (it didn't have any actual Typescript code at this point anyway due to the ongoing changes on other works streams that were pointed out above as well.) Fixes hyperledger-cacti#496 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
takeutak
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full build with frontend components included are now working
once again.
shipping the standard typescript-axios client types such as DefaultApi,
Configuration and the likes. This is because we hollowed out the
client-api package to only contain the extensions to these generated
types mentioned above (provided via typescript-axios OpenAPI generator)
This is part of a larger ongoing effort where we decoupled the api-client
and the cmd-api-server packages where earlier there was some tangling
between the two in the form of the cmd-api-server exporting it's
openapi spec onto the api-client package which in hindsight didn't
make much sense to be honest. Mistakes were made, but now are being
fixed.
we also deleted the remnants of the generated code from the api-client
package, e.g. the whole ./generated/openapi/typescrit-axios/ folder is
now gone properly (it didn't have any actual Typescript code at this
point anyway due to the ongoing changes on other works streams
that were pointed out above as well.)
Fixes #496
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com