Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): missing uuid from plugins #529 #530

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Feb 3, 2021

Adds the missing dependency "uuid" to the packages where applicable.

Fixes #529

@petermetz petermetz added the bug Something isn't working label Feb 3, 2021
@petermetz petermetz added this to the v0.4.0 milestone Feb 3, 2021
@petermetz petermetz enabled auto-merge (rebase) February 3, 2021 00:08
@petermetz petermetz force-pushed the fix/deps/missing-uuid-from-plugins-529 branch from c288322 to 0fbdd44 Compare February 3, 2021 00:09
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes hyperledger-cacti#529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the fix/deps/missing-uuid-from-plugins-529 branch from 0fbdd44 to 0308dd8 Compare February 3, 2021 00:26
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 04ea8bb into hyperledger-cacti:main Feb 7, 2021
@petermetz petermetz deleted the fix/deps/missing-uuid-from-plugins-529 branch February 8, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(deps): missing uuid from plugins
3 participants